MAAP-Project / maap-eoapi

MAAP STAC infrastructure
Apache License 2.0
0 stars 2 forks source link

Add git related tags to CDK stack #8

Closed emileten closed 1 year ago

emileten commented 1 year ago

Added the following tags to the maap-cdk-pgstac stack to make it easier to know what the stack was deployed from. With this, if someone in the future other than the person who made the deployment discovers the stack on the AWS console, it's going to be easier to identify the repo and the version of the repo from which the deployment was operated.

These are passed in the action workflow yaml.

Minor : I modified a print statement in the deploy.sh script, which should be used for manual deployment. Instead of printing all the environment variables required for the stack (one should look at config.ts to know what's required), I am just printing what's imported using the AWS CLI.

jjfrench commented 1 year ago

I'd instead suggest tagging the repo, adding that tag and keeping the project tag (remove the others). I'm more in favor of naming stacks to the repository. Like "maap-cdk-pgstac-dev-vpc", similar to already existing "maap-data-pipelines-dev-lambda"

emileten commented 1 year ago

Me to create a ticket to use github tags rather than commit sha. It would add structure to the versioning -- the version associated with a specific deployment would be more discoverable, and it would be easier to differentiate deployment changes to staging / production depending on what kind of update we're releasing (bug fix, feature, breaking change...).

Will merge this for now, and address the ticket in another PR.