MADEAPPS / newton-dynamics

Newton Dynamics is an integrated solution for real time simulation of physics environments.
http://www.newtondynamics.com
Other
936 stars 182 forks source link

don't assume android phones use ARM or computers dont in cmakelists.txt #255

Open tigercoding56 opened 2 years ago

tigercoding56 commented 2 years ago

in the cmakelists txt there is a line if not android add option -msse3 this assumes that the user uses a compatible architecture which is generally a bad idea because you can run almost any os on ARM and via versa so you could replace it with
for example : (its not in code tags because its a example )

if(CMAKE_PLATFORM_NAME == x86) add_definition(-msse2) elif(CMAKE_PLATFORM_NAME == x86_64) add_definition(-msse2) elif(CMAKE_PLATFORM_NAME == ARM) add_definition(-mneon) endif()

JulioJerez commented 2 years ago

Does Arm supports -MSS3

I thought is was neo intrinsics.

On Sun, Sep 12, 2021, 2:33 PM tigercoding56 @.***> wrote:

in the cmakelists txt there is a line if not android add option -msse this assumes that the user uses a compatible architecture which sometimes they do not so maibe you could replace it with if not architecture == ARM add option -msse

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MADEAPPS/newton-dynamics/issues/255, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6EPJF6CAIVGNXJSZHQB6LUBUMBVANCNFSM5D4QJ65A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.