search

MADEAPPS / newton-dynamics

Newton Dynamics is an integrated solution for real time simulation of physics environments.
http://www.newtondynamics.com
Other
928 stars 183 forks source link

Make Github action more generic. #295

Closed olitheolix closed 1 year ago

olitheolix commented 1 year ago

Refactor the existing Linux Github action to be more reusable for Windows and MacOS targets. The changes are purely cosmetic for now and still only target Linux.

I also tried to create a successful action for Windows but failed. I got the compilation to work but the linking failed. Hopefully, someone with more Windows experience can add a working Github action for Windows and MacOS one day.

JulioJerez commented 1 year ago

merged. the other day I committed something and I had a report from github saying that it fail in Linux, which was very nice.

I never worked with cmake actions before. I will see this weekend how that can be activated. that sounds like a cool feature to have. Thanks.

olitheolix commented 1 year ago

the other day I committed something and I had a report from github saying that it fail in Linux, which was very nice.

I am happy to hear that the CI has already come in handy for you.

I never worked with cmake actions before. It is rather straightforward to add a Windows runner but I could not figure out why it failed to build Newton. It is probably something trivial but I could not figure out what. I will file a PR with the Windows runner; maybe you can spot what is wrong.