search

MALES-project / SpeckleCn2Profiler

:satellite: :cyclone: A platform to use speckle patterns to describe atmospheric turbolence
MIT License
3 stars 0 forks source link

Add bump_version #28

Open luisaforozco opened 3 months ago

luisaforozco commented 3 months ago

Let's use bump_my_version and setup the CI/CD to automate the bumping of the version every time we make a release. Right now in setup.py there is: 

version='{{VERSION_PLACEHOLDER}}',

That is gotten from the action pypi_release.yaml as steps.tag.outputs.TAG_NAME.

SCiarella commented 3 months ago

bump-my-version fails when called in the github action, see for example here. However, I can execute it locally, so I do not understand this problem.

luisaforozco commented 3 months ago

The reason for using python 3.11.1 instead of python 3.11 is because of other dependencies like lie_learn?

SCiarella commented 3 months ago

The bump action has been fixed. Still, the publication does not work due to the outdated version of lie_learn on pypi.

luisaforozco commented 3 months ago

What about using python 3.10 for the publish action?

SCiarella commented 3 months ago

The problem is this

ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Can't have direct dependency: lie-learn@                               
         git+https://github.com/AMLab-Amsterdam/lie_learn. See                  
         https://packaging.python.org/specifications/core-metadata for more     
         information.

which is caused by requiring lie-learn@ git+https://github.com/AMLab-Amsterdam/lie_learn (pypi does not like git versions). If I simply require the pypi version lie_learn, then speckcn2 could be uploaded on pypi, but it would not build.

v1kko commented 3 weeks ago

the dependency problem is fixed in #35