search

MAOXIONGKAI / pe

0 stars 0 forks source link

Message for delete command confirmation is unclear and not very helpful #3

Open MAOXIONGKAI opened 2 weeks ago

MAOXIONGKAI commented 2 weeks ago

image.png

As shown in the screenshot, after delete person 2 command, the program shows a confirmation message which is Are you sure you want to delete this person? All events tied to this person will be deleted and this person will no longer show in any event's contact list. (Y/N).

Even this confirmation message reminds me of the possible consequence of deletion, but it is not very helpful when I want to confirm whether I am deleting the correct person, this feature can be developed in better way in which the message can show the details of the person to be deleted as a way of confirmation but the current program fails to implement this, which I think should be considered as feature flaw.

nus-pe-script commented 1 week ago

Team's Response

Our team implemented this extra prompt to serve as an added layer of confirmation to prevent accidental deleting. We believe that this command is serving its purpose, although we understand where you might be coming from.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: This issue does not qualify as NotInScope, because it does not fulfill the requirement.

image.png

This can be clearly seen in the team's user guide, when pressing Y or y for confirmation of the deleting the specified person, the details of this deleted person is clearly shown in the command window.

image.png

This implies that including the deleting person's detail is not a "better implementation that will take significantly more effort than the current implementation", as the current implementation can be tweaked slightly to fulfill this feature in much better way. (The program can make use of the index supplied by the user to find the detail of the person to be deleted and display them in the same format as shown in the above message, which should only involve several lines of code only)

Therefore, this issue should be accepted as NotInScope and should be FeatureFlaw instead. However, I do agree with the new severity proposed by the team.

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]