MAOXIONGKAI / pe

0 stars 0 forks source link

Celebrity name search for add event command is not case-insensitive #4

Open MAOXIONGKAI opened 2 weeks ago

MAOXIONGKAI commented 2 weeks ago

Currently, the find person command finds person based on case-insensitive search. However, this search method is not the same when using add event command.

As you can see in the screenshot, if input is c/alex yeoh, I can't create an event for alex yeoh because the name does not match by case.

image.png

However, if I input the exact name, like c/Alex Yeoh, then the command went through and create the event.

image.png

Even though this way of handling name search alone may still be valid because one may argue that name should be case-sensitive by nature, but I think the consistency in handling this kind of search across different commands may hinder the usage of the app because it does not follow user habit when inputting commands. User may end up wondering how come this input format works in this command but not in the other, hence I would consider this as a bug

nus-pe-bot commented 1 week ago

Team's Response

Due to the current implementation of our name being case sensitive, we have to make our searching functions case sensitive as well if not it will be searching the wrong person, hence the team believes that this implementation is not a bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: image.png

As according to the tP admin section, names should not be case-sensitive in the first place, therefore implementing the name in case-sensitive way itself is already considered as Featureflaw, the current find person accidentally does a good job because it is based on case-insensitive search of keywords but your other deliberate features ends up being incorrect. This kind of inconsistency makes the app a lot harder to use because user would get confused why searching by alex correctly gives the result of Alex Yeoh but gives error message for add event command. Therefore, the issue should be accepted as severity.Low feature flaw