Describe the feature. What should a user be able to do?
We should re-implement the number-format and format-date helper functions from ember-string-helpers
Why do we need this feature?
We used to use the external library to format dates and numbers (particularly in the development info panel). However, because of a deprecation warning, we decided to remove the ember-string-functions library while updating our Ember version. We added a couple of simple placeholder helper functions in this commit that move the date/number value into the Handlebars view, but the dates/numbers are unformatted. So, for example, dates are printed as "Tue Apr 24 2018 15:45:17 GMT-0400 (EDT)" and numbers as "2000000".
Alternatives
We could have stuck with the library and old version of Ember, but that was getting unstable.
Describe the feature. What should a user be able to do? We should re-implement the
number-format
andformat-date
helper functions from ember-string-helpersWhy do we need this feature? We used to use the external library to format dates and numbers (particularly in the development info panel). However, because of a deprecation warning, we decided to remove the
ember-string-functions
library while updating our Ember version. We added a couple of simple placeholder helper functions in this commit that move the date/number value into the Handlebars view, but the dates/numbers are unformatted. So, for example, dates are printed as "Tue Apr 24 2018 15:45:17 GMT-0400 (EDT)" and numbers as "2000000".Alternatives We could have stuck with the library and old version of Ember, but that was getting unstable.