MASQ-Project / MASQ-Node-issues

This repo contains the issues that are used for planning MASQ Node product work. It has no code in it, only GitHub issue tickets
https://masq.ai/
31 stars 12 forks source link

Upgrade primative-types #517

Open FinsaasGH opened 2 years ago

FinsaasGH commented 2 years ago

This is one of the more basic crates, but it communicates with everything else, so it a very challenging one to upgrade

This is going to be very perilous with affecting web3 types and libraries

bertllll commented 2 years ago

For GH-503 I may need to keep version 0.5.0. Can you put this off until GH-503 is fully played, please? Then we will see if it breaks anything on it.

masqrauder commented 5 months ago

This will be obsolete/irrelevant if we adopt https://github.com/alloy-rs (the planned successor to https://github.com/ethers-rs) which I recommend. We'd prefer to do a single migration instead of 1 from rust-web3 to ethers-rs and another from ethers-rs to alloy-rs. The benefits of alloy-rs include improved Rust datatypes (e.g. uint256) perhaps even native flavors; Solidity macros; Flexible http transports; async/await; hardware wallets and other hardware keys for signing transactions.