MCMrARM / mcpelauncher-linux

Please note this is a legacy repository, please go to: https://github.com/minecraft-linux/mcpelauncher-manifest/wiki
GNU General Public License v3.0
312 stars 46 forks source link

Win 10 Edition #410

Closed Madis0 closed 6 years ago

Madis0 commented 6 years ago

Could this be also used for running the Windows 10 Edition? Assuming the user extracts any needed files first.

lukeeey commented 6 years ago

No, it could not. If you want to run the Windows 10 Edition then buy Windows 10 because this project does the exact same.

Madis0 commented 6 years ago

No, it is not the same. The same would be saying "go buy an (Android) phone" or "go get an emulator" (compared to using a Windows virtual machine).

The question is rather about whether this program runs an Android application or the underlying native code. If latter, my suggestion would be doable.

lukeeey commented 6 years ago

It runs the native code.... Windows 10 Edition and MCPE have virtually the same codebase, just configured differently.

And no, your solution would not work. Windows 10 Edition is compiled for Windows, the Android version is compiled for Android, a Linux based operating system.

MCMrARM commented 6 years ago

It can not be used to run the Win 10 Edition executable, because that one has no symbols and uses Win32/WinRT APIs, and not the Linux ones like Android does.

The code base is indeed basically the same, and you lose nothing running the Android build instead of Win10.

MCMrARM commented 6 years ago

If Windows 10 Edition had symbols, I'd definitely pick that one up, because it's 64-bit.

lukeeey commented 6 years ago

@MCMrARM You do lose the chat location at the bottom of the screen though

Madis0 commented 6 years ago

Thanks for clarifying. Just to be clear, I didn't suggest Windows 10 Edition because it would be any better from Android's, but just because it is free for Java Edition users 😀

MCMrARM commented 6 years ago

@lukeeey I guess that's just a JSON thing that can easily be changed. If I'll have a while I'll look into making it look like that by default. @Madis0 heh, I guess so :D but well, unfortunately, it's not really possible (well actually, it's doable, it'd just 5x the effort of maintaining this launcher, that I'm not really willing to spend) due to that edition lacking symbol information.

lukeeey commented 6 years ago

@MCMrARM i guessed it was because you set the game version to pe to fix some problem instead of leaving it as win 10.