search

MCMrARM / mcpelauncher-linux

Please note this is a legacy repository, please go to: https://github.com/minecraft-linux/mcpelauncher-manifest/wiki
GNU General Public License v3.0
312 stars 46 forks source link

Does not contain a CMakeLists.txt file. #417

Closed MasterOfTheTiger closed 6 years ago

MasterOfTheTiger commented 6 years ago

Operating System: Linux Mint 19 (based on Ubuntu 18.04) Cmake version: 3.10.2 Install type: CEF and Gplay

This is outputted when I run cmake ... I have all dependencies listed installed. 

CMake Error at CMakeLists.txt:106 (add_subdirectory):
  The source directory

    /home/$USER/mcpelauncher-linux/gplay_api

  does not contain a CMakeLists.txt file.

CMake Error at CMakeLists.txt:107 (set_target_properties):
  set_target_properties Can not find target to add properties to: gplaydl

-- Configuring incomplete, errors occurred!
See also "/home/$USER/mcpelauncher-linux/build/CMakeFiles/CMakeOutput.log".
See also "/home/$USER/mcpelauncher-linux/build/CMakeFiles/CMakeError.log".
lukeeey commented 6 years ago

You didnt clone with --recursive

MasterOfTheTiger commented 6 years ago

@lukeeey It worked. Thank you. That should really be mentioned in the README and the wiki.

lukeeey commented 6 years ago

Personally i think people should just add that option when cloning any repo

MasterOfTheTiger commented 6 years ago

That makes sense, but if it does not work if you do not do it that way here, a lot of people can be left confused and making issues that do not need to be made. Also, what does recursive do exactly?

lukeeey commented 6 years ago

It clones all submodules too