search

MCSclimate / MCT

Model Coupling Tookit
Other
43 stars 18 forks source link

Add MPI_Get_library_version to mpi-serial #12

Closed rljacob closed 9 years ago

rljacob commented 9 years ago

Even though its an MPI 3.0 function, it would be very useful for identifying mpi-serial to other libraries, applications or configure systems.

Suggested by @quantheory.

rloy commented 9 years ago

I agree.

On Apr 30, 2015, at 5:52 PM, Robert Jacob notifications@github.com wrote:

Even though its an MPI 3.0 function, it would be very useful for identifying mpi-serial to other libraries, applications or configure systems.

Suggested by @quantheory.

� Reply to this email directly or view it on GitHub.

rljacob commented 9 years ago

Does that mean you'll implement it? :)

rloy commented 9 years ago

Yes.

On Apr 30, 2015, at 18:26, Robert Jacob notifications@github.com wrote:

Does that mean you'll implement it? :)

— Reply to this email directly or view it on GitHub.

quantheory commented 9 years ago

:dancer:

Once this is added I will update the CMake test.

rloy commented 9 years ago

Sean,

Were you hoping to have the string contain anything in particular? e.g. is "mpi-serial" sufficient ?

Ray

On Apr 30, 2015, at 11:39 PM, Sean Patrick Santos notifications@github.com wrote:

Once this is added I will update the CMake test.

� Reply to this email directly or view it on GitHub.

quantheory commented 9 years ago

I figured I'd leave it up to you. I think that any string that's unique to mpi-serial is fine, though you might also want to add a version number (e.g. "mpi-serial v2.0") just in case that becomes useful in the future).

rloy commented 9 years ago

I can hardcode the version like that but I don't know of an easy way to tie it to the git version - open to suggestions.

On May 2, 2015, at 4:37 PM, Sean Patrick Santos notifications@github.com wrote:

I figured I'd leave it up to you. I think that any string that's unique to mpi-serial is fine, though you might also want to add a version number (e.g. "mpi-serial v2.0") just in case that becomes useful in the future).

� Reply to this email directly or view it on GitHub.

rljacob commented 9 years ago

I don't think we need to worry about that. It wouldn't help to link it to the hash so we just have to remember to update that string when a new version is tagged.

rljacob commented 9 years ago

@rloy, how is this coming along?

rloy commented 9 years ago

I added that a few weeks back.

-Ray

On May 20, 2015, at 22:26, Robert Jacob notifications@github.com wrote:

@rloy, how is this coming along?

— Reply to this email directly or view it on GitHub.

rloy commented 9 years ago

https://github.com/MCSclimate/MCT/commit/4354ad6edabd94092ef0cc2c223fe88ec0854753

On May 20, 2015, at 10:26 PM, Robert Jacob notifications@github.com wrote:

@rloy, how is this coming along?

� Reply to this email directly or view it on GitHub.

rljacob commented 9 years ago

Thanks! I must have missed that message.

Issue resolved by 4354ad6edabd94092ef0cc2c223fe88ec0854753