MD-Anderson-Bioinformatics / NG-CHM_GUI_BUILDER

Simple graphical builder for Next-Generation Clustered Heat Maps
GNU General Public License v2.0
1 stars 1 forks source link

Heat Map Attributes: Fails with error message if blank line entered after last attribute. #56

Open jmelott opened 1 year ago

jmelott commented 1 year ago

If a blank line is entered anywhere else in the attributes list, it works fine. If a blank line is entered after the last attribute, user gets the following error message, but it is not easy to see that there is a blank line after the last attribute. ERROR: Bad attribute value entered. Attributes must be entered as value pairs separated by a colon (:).

jmelott commented 1 year ago

This is leaving a new attribute setting of just a colon on the last line. It's not causing the error any more, but should we be allowing attributes with blank names and values?

bmbroom commented 1 year ago

I will disallow blank names but allow blank values.

I will also require names to start with a letter and consist only of letters, digits, hyphens, underscores, and periods.

jmelott commented 1 year ago

Still allowing blank names and names starting with numbers,