ENH: Simplify code of classification

ME-ICA / aroma

ICA-AROMA, as a Python package. A work in progress.

Apache License 2.0

7 stars 11 forks source link

ENH: Simplify code of classification #28

Open oesteban opened 3 years ago

oesteban commented 3 years ago

Also, change the function name and signature to "predict(X)" to make it more similar to scikit-learn.
Also, remove runICA and the other function for registration.

Closes # .

Changes proposed in this pull request:

-

oesteban commented 3 years ago

Don't you prefer to go step by step with targeted PRs? We can deal with the CLI once we have a functional prototype.

oesteban commented 3 years ago

Once again, the CLI is literally the last thing I would care for :D

handwerkerd commented 2 years ago

The core of the component classification code in tedana is that each classification step is its own function. I don't think it's realistic to completely harmonize the two sets of classification codes now, but if you set it up so that each classification decision is modularized, it should be realistic to use the same system for both in the near future.

eurunuela commented 2 years ago

Ok guys, I've made the following changes:

The function to save the metrics write_metrics has been moved to io.py.
The classification is done in classification.py with a function for each criteria as @handwerkerd mentioned.

What do you think @tsalo @cesarcaballerogaudes @oesteban?

Edit: no idea why the style check fails.