Open tsalo opened 3 years ago
My only concern is: can I react with a bigger thumbs-up emoji? 😅
I can't think of any drawbacks, to be honest.
@ME-ICA/tedana-devs does anyone have an issue with this? I could get a PR done pretty quickly if everyone is okay with it.
I'm not incredibly familiar with potential drawbacks - as long as it is more or less possible to open with default utilities on all platforms and isn't (too) slow to cycle between multiple, then I say go for it. Seems like a clear potential upgrade.
I'm in favour of using svg, but I'll mention a few potential drawbacks anyways:
@notZaki thanks for the info about svg files. I am not as familiar with the different formats so it's great to have the drawbacks compiled. It sounds like we should be fine as long as we (1) update the documentation a little bit so users know how to open the files and (2) adjust the matplotlib settings for the files.
Perhaps it should be an option? I kind of hate to suggest it, because I know it is annoying, but I wouldn't think about using a web browser as my goto option - I don't deal with svgs often. I think the default being svg is a good choice, given the potential benefits, but I'm imagining someone cursing our name because it is now a struggle to quickly cycle through images. I know in the past I've wanted to quickly jump through a series of images, or use feh
on linux to spin through them from the terminal.
Summary
I think SVG files are more useful for manuscripts than PNG files, but I'm not sure what (if any) drawbacks there would be to switching. Please weigh in if you have a concern.
Yea: :+1: Nay: :-1:
Next Steps