Incorrect code for quote-mode DEL

MEGA65 / open-roms

A project to create unencumbered open-source ROMs for use on selected retro computers

Other

263 stars 18 forks source link

Incorrect code for quote-mode DEL #39

Closed mist64 closed 4 years ago

mist64 commented 4 years ago

If you type the following:

?ASC("")

Then navigate between the "" and type

<INST><DEL>

The character that shows up is an reverse semicolon. The result of the expression is 187.

Instead, a reverse T should show up, and the result should be 20.

FeralChild64 commented 4 years ago

Character printed is now fixed in my branch (https://github.com/FeralChild64/open-roms/commit/dea993e4b72b1ca57cb6b05f01eefcf5e75a5df8) - I didn't notice the .A got overridden at some point of this flow.

But the ASC result is still incorrect (148 now). Probably the original CHRIN (_chrin_enterloop in our code) does some kind of translation which is not implemented in Open ROMs. This will need more in-depth investigation.

[edit] Probably _screen_code_topetscii routine needs to be checked, possibly we should implement this table: https://sta.c64.org/cbm64scrtopetext.html

FeralChild64 commented 4 years ago

Commit https://github.com/FeralChild64/open-roms/commit/af1f5b079d885bb5cbf7898ab7e18c47056c664a (together with previous one) should fix the issue.

BTW. Thanks for all the remarks!

FeralChild64 commented 4 years ago

Problem fixed in the commit mentioned above.