MEGA65 / open-roms

A project to create unencumbered open-source ROMs for use on selected retro computers
Other
263 stars 18 forks source link

token search routine goes funny at TAB( #9

Closed gardners closed 3 years ago

gardners commented 5 years ago

All keywords after TAB( when displayed are wrong.

To reproduce, type the keyword in direct mode on a line by itself. It should echo back out verbatim.

gardners commented 5 years ago

Fixed page-wrap problem.

Now most tokens work, except oddly (and perhaps cooincidentally) TAB( doesn't match.

Verify all others, and figure out cause.

gardners commented 5 years ago

Position in the list doesn't seem to affect it. Also all the single-character math operators and relational operators don't get detected.

gardners commented 5 years ago

Also confirmed it is not the word boundary check that it is failing. It just seems to not match it. However the string it compresses to matches what compress_text.c compressed it to originally. Presumably there is some subtle bug in there.

The math operators might be getting too many end byte sequences on the end of their sequences in pack_word.

FeralChild64 commented 3 years ago

Since the bug report was issued, the tokeniser has been rewritten. Current one seems to handle "TAB(" correctly (produces same results as original C64 ROM tokeniser), display issues seems to be solved too.