search

MFlowCode / MFC

Exascale simulation of multiphase/physics fluid dynamics
https://mflowcode.github.io
MIT License
144 stars 67 forks source link

Some subroutines are both manually inlined and still exist as separate subroutines #53

Closed sbryngelson closed 1 year ago

sbryngelson commented 1 year ago

Issue: Some subroutines are both manually inlined and still exist as separate subroutines. For example: in m_weno, the s_preserve_monotonicity exists but is never called because it was manually inlined. I suspect there are probably others like this, it is just the one I found.

Question: Is it necessary to manually copy/paste this subroutine into the s_weno subroutine? What are the performance tradeoffs?

Expected action: I suspect the additional cost associated with manually placing these routines into the main code is not worth the longer, more confusing code it creates. If we pursue this strategy, we could theoretically just have one extremely long subroutine that "does everything" and reap some small performance benefit, but I suspect that we agree this isn't a good idea.

sbryngelson commented 1 year ago

@henryleberre @anandrdbz is this issue resolved?

sbryngelson commented 1 year ago

This issue appears to be fixed.