重複するテクスチャを除去

nokonoko1203 commented 1 week ago

Close #639

What I did（変更内容）

3D Tiles・OBJ・glTFでテクスチャが重複しないように調整
メインの処理はatlas-packerで対応
- https://github.com/MIERUNE/atlas-packer/pull/16

Notes（連絡事項）

None / なし

coderabbitai[bot] commented 1 week ago

Walkthrough

このプルリクエストでは、cesiumtilesモジュールのtile_writing_stage関数において、TexturePackerからAtlasPackerへの移行が行われ、テクスチャのパッキングと管理方法が変更されました。また、GltfSinkおよびObjSinkの実装においても、テクスチャパッキングに関連する機能がコメントアウトされ、一時的に無効化されました。全体として、テクスチャ管理に関する機能が大幅に整理され、コードの構造が改善されました。

Changes

ファイルパス	変更概要
nusamai/src/sink/cesiumtiles/mod.rs	`tile_writing_stage`関数で`TexturePacker`から`AtlasPacker`に移行し、テクスチャのパッキングロジックを改善。機能処理のロジックが再構築され、`generate_texture_id`クロージャが追加されました。
nusamai/src/sink/gltf/mod.rs	`GltfSink`のテクスチャパッキング関連のコードがコメントアウトされ、機能が一時的に無効化。`run`メソッドは`unimplemented!()`プレースホルダーを含む。
nusamai/src/sink/obj/mod.rs	`ObjSink`の`TexturePacker`機能がコメントアウトされ、`run`メソッドも`unimplemented!()`に変更。テクスチャの追加やエクスポートに関する処理が無効化されました。

Assessment against linked issues

Objective	Addressed	Explanation
重複するテクスチャを集約 (#639)	❌	テクスチャの重複をまとめる機能は実装されていない。

Poem

🐰 うさぎの歌
テクスチャの旅、変わりゆく道、
アトラスの夢、色とりどりの模様。
みんなで集まる、機能の舞、
新たな光、コードの中で輝き。
うさぎも踊る、喜びの声、
変更の風に乗り、未来へと進もう！ 🌈

:placard: Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 46.60422% with 228 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
nusamai/src/sink/obj/mod.rs	0.00%	206 Missing :warning:
nusamai/src/sink/cesiumtiles/mod.rs	89.28%	12 Missing :warning:
nusamai/src/sink/gltf/mod.rs	90.82%	10 Missing :warning:

Additional details and impacted files

| [Components](https://app.codecov.io/gh/MIERUNE/plateau-gis-converter/pull/648/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MIERUNE) | Coverage Δ | | |---|---|---| | [GUI](https://app.codecov.io/gh/MIERUNE/plateau-gis-converter/pull/648/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MIERUNE) | `∅ <ø> (∅)` | | | [Backend](https://app.codecov.io/gh/MIERUNE/plateau-gis-converter/pull/648/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MIERUNE) | `74.01% <46.60%> (-0.18%)` | :arrow_down: | | [Libraries](https://app.codecov.io/gh/MIERUNE/plateau-gis-converter/pull/648/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MIERUNE) | `89.73% <ø> (+0.03%)` | :arrow_up: |

:loudspeaker: Thoughts on this report? Let us know!

MIERUNE / plateau-gis-converter