Visit detail column names are inconsistent

[alistairewj]

The visit detail table has some columns:

• admitting_source_concept_id
• admitting_source_value
• discharge_to_concept_id
• discharge_to_source_value

This seems inconsistent for two reasons:

1. "admitting" and "discharge" are different tenses (perhaps it should be "admission")
2. admitting_source_concept_id contains the word "source" but discharge_to_concept_id does not

I think, regarding (2), that it is an error. The description is: "A foreign key to the predefined concept in the Place of Service Vocabulary reflecting the admitting source for a visit.". So I think that the idea is: admitting_source_value is the original data, and next to it we should have admitting_concept_id for the standardized data, not admitting_source_concept_id. (Actually, I'd further argue it should be admission_concept_id). Thoughts? I could raise this at OHDSI if we agree.

[parisni]

yeah exactly totally agreed

[tompollard]

Agreed!

[alistairewj]

Sounds good, I'll raise this issue on the OMOP CDM repository.