search

MIT-PSFC / disruption-py

An open-source physics-based Scientific Framework for Disruption Analysis of Fusion Plasmas for AI/ML applications
https://mit-psfc.github.io/disruption-py/
MIT License
11 stars 0 forks source link

Update makefile and workflows #327

Closed gtrevisan closed 1 month ago

gtrevisan commented 1 month ago

revamp the makefile to allow the same shortcuts to mean different things locally and in CI/CD workflows.

running make lint:

EDIT: also added a make check target to run lint in CI/CD conditions.

behavior for pylint, shellcheck, and yamllint will not change.

furthermore, to fully exploit poetry virtual env caching, always install all dependencies in CI/CD workflows.

tests of this makefile are appreciated!

gtrevisan commented 1 month ago

yes, that code was introduced in pylint 3.3, that means you are running pylint 3.2 and asking of pylint to conceive the new code, which it does not. I have a postmortem ready, we can talk about it later. just run make install again on your local setup.