MIT-PSFC / disruption-py

An open-source physics-based Scientific Framework for Disruption Analysis of Fusion Plasmas for AI/ML applications
https://mit-psfc.github.io/disruption-py/
MIT License
11 stars 0 forks source link

Update readme files #338

Closed gtrevisan closed 2 weeks ago

gtrevisan commented 1 month ago

preview: https://github.com/MIT-PSFC/disruption-py/blob/update-readmes/README.md

amdecker commented 1 month ago

Given the readme mentions SPARC, I'll add that at CFS there's encouragement to use the word "device" or "machine" (and later, hopefully, "power plant") instead of "reactor" to have a strong differentiation between fusion projects and fission projects. https://github.com/MIT-PSFC/disruption-py/blob/74d4c150eae0083895f38253d741a12caf61cb8c/README.md?plain=1#L29

gtrevisan commented 3 weeks ago

@amdecker how should we solve the duplicated information between README.md and docs/index.md? copy/paste? (actually, IMHO we should use the mkdocs webpage with caution for now -- eg for automated API documentation and any technical Q&A...)

amdecker commented 3 weeks ago

@amdecker how should we solve the duplicated information between README.md and docs/index.md? copy/paste? (actually, IMHO we should use the mkdocs webpage with caution for now -- eg for automated API documentation and any technical Q&A...)

One idea would be we could add this to our docs/index.md --8<-- "README.md" which would insert the contents of the readme file into the docs. If we do that, we would need to change a few of the relative links to be absolute.

gtrevisan commented 3 weeks ago

@amdecker is this good to go wrt the docs?