MLH-Fellowship / 0.4.2-learning-journal

A React Native/GraphQL based application for running a 'Learning Journal'
MIT License
3 stars 3 forks source link

added home-screen and Journal Feed #11

Closed Xtremilicious closed 4 years ago

Xtremilicious commented 4 years ago

Description

Designed and developed the home page for the app, according to the mock UI. The files added include screens/Home.js,components/ArticleList.js, components/ArticlePost.js, components/ArticlePost2.js (static article posts for now). Just replace the HomeScreen in BottomTabNavigation file with Home. Let me know if any changes need to be made.

Journal Feed Screen added! Check out JournalFeed.js inside the screens folder.

Fixes #10

Type of change

Screenshots of the change

AnshG714 commented 4 years ago

We should migrate the colours in the StyleSheet object to the constants in the Colors.js file. It's easier to manage colors like that.

Xtremilicious commented 4 years ago

We should migrate the colours in the StyleSheet object to the constants in the Colors.js file. It's easier to manage colours like that.

Yeah, working on it! Ansh's commit needs to be merged so that the Colors file is updated, after which I will push another commit modifying the hardcoded colours.

Xtremilicious commented 4 years ago

There are two files for ArticlePost and JournalPost. It looks like they are the same, only the content is different. Can we make them reusable components and pass on the information as props to them?

Actually, the styling (fonts) and the views are a little different, I think we can take this up later as an improvement update.