MM2-0 / Kvaesitso

A search-focused Android launcher
https://kvaesitso.mm20.de/
GNU General Public License v3.0
2.54k stars 87 forks source link

dynamic articon icon pack doesnt changes #519

Open ansarimohammed422 opened 1 year ago

ansarimohammed422 commented 1 year ago

It doesn't changes when changing wallpaper

I have turned on dynamic icon setting in icon section in launcher

The launcher colour changes

It is not working from this latest release

But it was working fine on previous release

exstntlmsnthrp commented 1 year ago

I can confirm this as well. The icons do not automatically change.

Steps to reproduce:

Screenshot_arcy-gr.png

Screenshot_arcy-bl.png

In the second screenshot, the icons should have changed to blue. They will change if you manually go to kvaesitso settings and disable material you and then re-enable them.

Following is what it should look like.

Screenshot_20230828-074348_Kvaesitso.png

Crazy-Unicooorn commented 1 year ago

Might be related: the toggle button to change the theme of the icon pack doesn't work either after 1.17

Screenshot_20230828_233025_Kvaesitso.jpg

This button on the right on the screenshot. Previously it was changing how the icons look (I think kind of a dark/light mode toggle), now it just doesn't do anything.

MM2-0 commented 1 year ago

I can't reproduce either issue. What Android versions are you using?

ansarimohammed422 commented 1 year ago

Android 13 Miui 14

Crazy-Unicooorn commented 1 year ago

Android 13 One Ui 5.1

Here is a video of my issue:

https://github.com/MM2-0/Kvaesitso/assets/30509883/2f2e1405-18f8-4150-bb85-dffb26cae7db

exstntlmsnthrp commented 1 year ago

I'm using LineageOS 20 (Android 13) on Pixel 7 Pro.

exstntlmsnthrp commented 1 year ago

Might be related: the toggle button to change the theme of the icon pack doesn't work either after 1.17

Screenshot_20230828_233025_Kvaesitso.jpg

This button on the right on the screenshot. Previously it was changing how the icons look (I think kind of a dark/light mode toggle), now it just doesn't do anything.

@Crazy-Unicooorn I suspect what you reference here is more related to the icon pack and not kvaesitso. The button in your screenshot works with Arcticons dark or light. I can confirm it does not work with Arcticons You, but I believe that is the intended behaviour as they are material you and should change automatically.

Crazy-Unicooorn commented 1 year ago

Might be related: the toggle button to change the theme of the icon pack doesn't work either after 1.17

Screenshot_20230828_233025_Kvaesitso.jpg

This button on the right on the screenshot. Previously it was changing how the icons look (I think kind of a dark/light mode toggle), now it just doesn't do anything.

@Crazy-Unicooorn I suspect what you reference here is more related to the icon pack and not kvaesitso. The button in your screenshot works with Arcticons dark or light. I can confirm it does not work with Arcticons You, but I believe that is the intended behaviour as they are material you and should change automatically.

I don't think so, because before the newest release it was changing how the icons look. You could switch so that instead of the accent color being on the background it was on the lines of the icons.

I know it for a fact because what happened is that I was using the other style, I updated Kvaesitso, it changed all my icons, I tried putting the other style back by pressing the toggle, and that's how I discovered there is a bug, as it didn't do anything.

exstntlmsnthrp commented 1 year ago

Interesting. I only say this because, for me, that toggle never did anything to change the Arcticons You, only the two original (dark/light) packs as I shared.

Crazy-Unicooorn commented 1 year ago

I see. Then I don't know why I was able to get this, but here is what my icons looked like before the update:

Screenshot_20230830_131809_TikTok.jpg

Here is what they look like now:

Screenshot_20230830_131844_TikTok.jpg

And I clearly remember playing with this toggle when it was working, to choose which version I liked better.

exstntlmsnthrp commented 1 year ago

I see what you say. I didn't doubt you, but agree that is rather odd. Whilst I have nothing to back this up, I wonder if it has to do with recent updates to the icon packs for Arcticons?

Crazy-Unicooorn commented 1 year ago

Sure no worries! I'm glad that you commented because it allows me to be more specific and share more details. Now I just hope I am not polluting this issue with something unrelated.

I wonder if it has to do with recent updates to the icon packs for Arcticons? I don't know, that might be the case yes! But I am quite sure I did not do both updates at the same time.

I will open an issue to the Arcticons repo, because the toggle does work for me with the other Arcticons icon packs (I just tried that). So it indeed sounds related to Arcticons You itself, which is weird to me as I remember being excited about updating Kvaesitso, going back to the homescreen after completion, and seeing my icons changed.

Edit: started a discussion in Arcticons' repo, just to be sure. https://github.com/Donnnno/Arcticons/discussions/1677

MM2-0 commented 1 year ago

I have changed the colors of themed icons, I've reverted them to pre 1.26. Maybe that's the issue here?

Donnnno commented 1 year ago

Hi! Here's a quick explanation on how Articons You works:

On devices that run on android 11 and lower, it switches to black and white for both values.

This seems like a launcher / system bug to me

Donnnno commented 1 year ago

My suggestion would be to check if nova or smart launcher have this issue too. Those implementations are probably the most reliable

MM2-0 commented 1 year ago

Oh, I see it now. I didn't read the "You" part. You are right, Arcticons You icons aren't themed properly. The other Arcticons packs work fine though.

Hi! Here's a quick explanation on how Articons You works: All lines use a color like system_accent_100 (idk the actual value atm), with a background that has like the opposite value. On devices that run on android 11 and lower, it switches to black and white for both values. This seems like a launcher / system bug to me

Here is what the launcher does (or at least what it is supposed to do) when you enable that "dynamic colors" toggle button:

In any case, the foreground layer is tinted with a color from the launchers color scheme (onPrimaryContainer) and the background is set to a solid color (primaryContainer)

This is different from what Archticons You does in launchers without dedicated themed icons support since

If you don't enable the toggle, the icons are used as is.

exstntlmsnthrp commented 1 year ago

Thanks for the explanation @MM2-0. That makes more sense.

ansarimohammed422 commented 1 year ago

I have found a fix for this issue

When we enable "Enforce themed icon" in settings the icon pack gets fixed and works dynamically.

But when will a permenant fix will be their