MMRIZE / MMM-anotherNewsFeed

This is just a request from specific user.
1 stars 0 forks source link

Change the side and position of the pictures #2

Closed 1Cedric1 closed 5 months ago

1Cedric1 commented 5 months ago

Dear @eouia, thank you for this module I would like to try. Are there parameters so change the size and move the picture (e.g. under the text)? Thank you for your interest and have a great day, Cédric

eouia commented 5 months ago

Let me see. It's possible for almost everything. But if you have a specific plan (like a sketch or picture), it will be a help.

1Cedric1 commented 5 months ago

Thank your for your prompt response.

a good example I think is visible on https://forum.magicmirror.builders/topic/8937/mmm-news

with fix px or % of the column.

size newsfeed

eouia commented 5 months ago

Yes. That was one of my other modules. You probably want to display your news module with a photo on the side (left or right). I'll try. wait for a while.

1Cedric1 commented 5 months ago

The version with the text on the top and the picture below would be better (as the picture with the tractor would be better I think, to see a larger picture.

eouia commented 5 months ago
image
eouia commented 5 months ago

There be small code modification needed.

Open your MMM-anotherNewsFeed/newsfeed.njk, Go to line 66; There would be codes like this;

       <div class="container {% if config.showImage and image %} withImage {% endif %}">
            {% if config.showImage and image %}
                <div class="newsfeed-image" style="background-image: url({{image}})"></div>
            {% endif %}
            <div class="newsfeed-article"> <!-- THIS LINE!!! -->
            {% if (config.showSourceTitle and sourceTitle) or config.showPublishDate %}
            ...

Move the line <div class="newsfeed-article">to upward like this.

        <div class="container {% if config.showImage and image %} withImage {% endif %}">
            <div class="newsfeed-article"> <!-- TO HERE -->
            {% if config.showImage and image %}
                <div class="newsfeed-image" style="background-image: url({{image}})"></div>
            {% endif %}
...

Then save it.

Then append this into your css/custom.css

.MMM-anotherNewsFeed {
  max-width: 400px;

  & .container.withImage {
    & .newsfeed-article {
      display: flex;
      flex-direction: column;

      & .newsfeed-image {
        order: 2;
        max-width: 400px;
        max-height: 300px;
        aspect-ratio: 1/1;
      }

      & .newsfeed-title {
        order: 1;
      }

      & .newsfeed-source {
        text-align: right;
        order: 4;
      }

      & .newsfeed-desc {
        order: 3;
      }
    }
  }
}

You can adjust max-width and max-height for your purpose.

1Cedric1 commented 5 months ago

Wow, looks great, well done !

I think this "improvement" will really be appreciated by the MMM community, even more because you've documented well in your depository.

All the best to you and contrats for your job!

eouia commented 5 months ago

To be honest, this module was built for custom order-made for just one specific user. So I had no idea to share with others. :)

1Cedric1 commented 4 months ago

hello @eouia sorry to disturb you a last time, but using the URL in the .config below, do you see the pictures ? The text appear, but the picture not. It worked well with another one I've used until now. Stange .. what do you think? Thank you in advance.

{ module: "MMM-anotherNewsFeed", header: "ANOTHER News Feed", position: "top_left", config: { feeds: [ { title: "20 minutes", url: "https://partner-feeds.20min.ch/rss/20minutes/suisse-romande", }, { title: "Le Matin", url: "https://partner-feeds.lematin.ch/rss/lematin/monde", }, { title: "1jour1actu", url: "https://www.1jour1actu.com/feed", }, { title: "RFJ", url: "https://www.rfj.ch/documents.rdf?idz=31&cid=9611", }, ], showImage: true, } },

eouia commented 4 months ago

Some newsfeeds might not have an image itself or a non-standard format. There is a standard format for RSS/ATOM/XML for news articles, but some feed providers might not keep the rule. In that case, dedicated modification might be needed. Which RSS feed doesn't show the image? I'll look inside the feed, tell me.

On Thu, Jun 27, 2024 at 8:14 AM 1Cedric1 @.***> wrote:

hello @eouia https://github.com/eouia sorry to disturb you a last time, but using the URL in the .config below, do you see the pictures ? The text appear, but the picture not. It worked well with another one I've used until now. Stange .. what do you think? Thank you in advance.

{ module: "MMM-anotherNewsFeed", header: "ANOTHER News Feed", position: "top_left", config: { feeds: [ { title: "20 minutes", url: "https://partner-feeds.20min.ch/rss/20minutes/suisse-romande", }, { title: "Le Matin", url: "https://partner-feeds.lematin.ch/rss/lematin/monde", }, { title: "1jour1actu", url: "https://www.1jour1actu.com/feed", }, { title: "RFJ", url: "https://www.rfj.ch/documents.rdf?idz=31&cid=9611", }, ], showImage: true, } },

— Reply to this email directly, view it on GitHub https://github.com/MMRIZE/MMM-anotherNewsFeed/issues/2#issuecomment-2193882896, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANECIUG4SXDOIDN577HODLZJOUU3AVCNFSM6AAAAABJ3TMOO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJTHA4DEOBZGY . You are receiving this because you were mentioned.Message ID: @.***>

1Cedric1 commented 4 months ago

OK, interesting, in fact.

the 4 feeds below I am currently using, are all working with the module MMM-NewsFeed from https://forum.magicmirror.builders/topic/14295/mmm-newsfeed this module is not maintained anymore, but it still works with text and picture on an "old" Magicmirror I have.

Because I am using a new raspberry now, I have to find a new module.

Now, in the Feed " https://partner-feeds.20min.ch/rss/20minutes/suisse-romande", the images for news articles are referenced like that : [image: Capture d’écran 2024-06-27 à 15.28.12.jpg]

In the feed https://partner-feeds.lematin.ch/rss/lem https://partner-feeds.lematin.ch/rss/lematin/mondeatin/monde https://partner-feeds.lematin.ch/rss/lematin/monde, the images for news articles are referenced like that :

[image: Capture d’écran 2024-06-27 à 15.32.12.jpg]

in the feed https://www.1jour1actu.com/feed, the images for news articles are referenced like that : [image: Capture d’écran 2024-06-27 à 15.34.43.jpg]

and in the feed https://www.rfj.ch/ https://www.rfj.ch/documents.rdf?idz=31&cid=9611 documents.rdf?idz=31&cid=9611 https://www.rfj.ch/documents.rdf?idz=31&cid=9611 the images for news articles are referenced like that :

[image: Capture d’écran 2024-06-27 à 15.36.12.jpg]

A real thanks for your help.

On Thu, 27 Jun 2024 at 08:38, Seongnoh Sean Yi < @.***> wrote:

Some newsfeeds might not have an image itself or a non-standard format. There is a standard format for RSS/ATOM/XML for news articles, but some feed providers might not keep the rule. In that case, de DuckDuckGo removed one tracker. More https://duckduckgo.com/-hGysyZFupsqvAi0nzhKiHW-qw9F3OqfyEDLQuQOUPwflN3RR9sz9PZaxtWRaNiUVYtIGeEymwADH4d2sFGXgIglxm2_uzW2YD12ZaDOhaSw6GlZqZrGonPBcFKDRZcRAQWCADCb6uaXECDfqSLdwYAJgki91JgszCwd3T_vByXyFP9Y--IT_6SoWsl150vvNWyKzbD1iSanD52-TpS-rG5fMe9ePAGKDlTqjefSJDLvhut8ZBX3fB6Ai_DhZ66sQBWu8PLvWltd-l6plmIsxJF1GSAXh-xy_AIVqE4U5LjClUcOk45DruA3myEJdpEkoedPIgeWnHOBZmyliVFzNUaQBDM7SUtak0VFU698itOMWUkP8Cr6QovD9Moiqbz46YWRQyeq9kcr06BNyLl9sdD5tMpcs2Bed5obU_gYhfjg5wXLajWGKDaZS9QdYPfI3OCobafbyVhHgT0s-onZplwYDlyVj49PevIEn9Mn1H-REXJqeKFl-VuApjiJvMQQc Report Spam https://duckduckgo.com/-hGysyZFupsqvAi0nzhKiHW-qw9F3OqfyEDLQuQOUPwflN3RR9sz9PZaxtWRaNiUVYtIGeEymwADH4d2sFGXgIglxm2_uzW2YD12ZaDOhaSw6GlZqZrGonPBcFKDRZcRAQWCADCb6uaXECDfqSLdwYAJgki91JgszCwd3T_vByXyFP9Y--IT_6SoWsl150vvNWyKzbD1iSanD52-TpS-rG5fMe9ePAGKDlTqjefSJDLvhut8ZBX3fB6Ai_DhZ66sQBWu8PLvWltd-l6plmIsxJF1GSAXh-xy_AIVqE4U5LjClUcOk45DruA3myEJdpEkoedPIgeWnHOBZmyliVFzNUaQBDM7SUtak0VFU698itOMWUkP8Cr6QovD9Moiqbz46YWRQyeq9kcr06BNyLl9sdD5tMpcs2Bed5obU_gYhfjg5wXLajWGKDaZS9QdYPfI3OCobafbyVhHgT0s-onZplwYDlyVj49PevIEn9Mn1H-REXJqeKFl-VuApjiJvMQQc

Some newsfeeds might not have an image itself or a non-standard format. There is a standard format for RSS/ATOM/XML for news articles, but some feed providers might not keep the rule. In that case, dedicated modification might be needed. Which RSS feed doesn't show the image? I'll look inside the feed, tell me.

On Thu, Jun 27, 2024 at 8:14 AM 1Cedric1 @.***> wrote:

hello @eouia https://github.com/eouia sorry to disturb you a last time, but using the URL in the .config below, do you see the pictures ? The text appear, but the picture not. It worked well with another one I've used until now. Stange .. what do you think? Thank you in advance.

{ module: "MMM-anotherNewsFeed", header: "ANOTHER News Feed", position: "top_left", config: { feeds: [ { title: "20 minutes", url: "https://partner-feeds.20min.ch/rss/20minutes/suisse-romande", }, { title: "Le Matin", url: "https://partner-feeds.lematin.ch/rss/lematin/monde", }, { title: "1jour1actu", url: "https://www.1jour1actu.com/feed", }, { title: "RFJ", url: "https://www.rfj.ch/documents.rdf?idz=31&cid=9611", }, ], showImage: true, } },

— Reply to this email directly, view it on GitHub < https://github.com/MMRIZE/MMM-anotherNewsFeed/issues/2#issuecomment-2193882896>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AANECIUG4SXDOIDN577HODLZJOUU3AVCNFSM6AAAAABJ3TMOO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJTHA4DEOBZGY>

. You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/MMRIZE/MMM-anotherNewsFeed/issues/2#issuecomment-2193912094, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOV2OXXJLHFPVG7XSXVU7SLZJOXNZAVCNFSM6AAAAABJ3TMOO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJTHEYTEMBZGQ . You are receiving this because you modified the open/close state.Message ID: @.***>

eouia commented 4 months ago

I'll look inside. Plz wait for a few days.

1Cedric1 commented 4 months ago

ok, thank you very much in advance and have a good week-end!

On Thu, 27 Jun 2024 at 16:19, Seongnoh Sean Yi < @.***> wrote:

I'll look inside. Plz wait for a few days. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID:

DuckDuckGo removed one tracker. More https://duckduckgo.com/-hGysyZFupsqvAi0nzhKiHW-qw9G3OpfwLmbSroxGkBOd_6qbom_15KmNty7JoTCzCog30nEiBBYjBv1sryMBDEOQy296f3TIbuDbTYkDXWnIwrNTMZFU74bkoQKHJioOAwAIZSPB1TYsTaNCXbOHGAMAkWexOEmQWDu6e9oeX-wp5qn-0BWzznjG3E61riPu5YBq3J5sMX2iP32ROX5pvTJ-1UI8DkajEyvgibGDNDPrufbSDv_tFrQK-Ow14ckdHpdYHU355rnfKC9yQLuakiyjJADy_4xfgEC3CcKclxhQquHQcch33gTxZiMs0CSUPOnmQvLRjHAszZazKixlUGsDQDC1lbSoNVZXOPXIrTpEz9l_glRSF94dJVGXz2REzi0xG7526mNYLwnpe68mfVLewP1PaykznecEQj2P6l6MDHJftKJbYYBplb5D1A1-js4Khdp_DZeJ2iozbejMQuGDQcpcsfPr7V5Ckfpm-o_yIC5NTRYuvSlyFMcRN5qAD Report Spam https://duckduckgo.com/-hGysyZFupsqvAi0nzhKiHW-qw9G3OpfwLmbSroxGkBOd_6qbom_15KmNty7JoTCzCog30nEiBBYjBv1sryMBDEOQy296f3TIbuDbTYkDXWnIwrNTMZFU74bkoQKHJioOAwAIZSPB1TYsTaNCXbOHGAMAkWexOEmQWDu6e9oeX-wp5qn-0BWzznjG3E61riPu5YBq3J5sMX2iP32ROX5pvTJ-1UI8DkajEyvgibGDNDPrufbSDv_tFrQK-Ow14ckdHpdYHU355rnfKC9yQLuakiyjJADy_4xfgEC3CcKclxhQquHQcch33gTxZiMs0CSUPOnmQvLRjHAszZazKixlUGsDQDC1lbSoNVZXOPXIrTpEz9l_glRSF94dJVGXz2REzi0xG7526mNYLwnpe68mfVLewP1PaykznecEQj2P6l6MDHJftKJbYYBplb5D1A1-js4Khdp_DZeJ2iozbejMQuGDQcpcsfPr7V5Ckfpm-o_yIC5NTRYuvSlyFMcRN5qAD

I'll look inside. Plz wait for a few days.

— Reply to this email directly, view it on GitHub https://github.com/MMRIZE/MMM-anotherNewsFeed/issues/2#issuecomment-2194830644, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOV2OXVULKGUKLDTEPM5YQTZJQNOTAVCNFSM6AAAAABJ3TMOO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJUHAZTANRUGQ . You are receiving this because you modified the open/close state.Message ID: @.***>

--

Diese Mitteilung ist nur für den adressierten Empfänger bestimmt. Sie kann persönliche und vertrauliche Informationen enthalten. Nehmen Sie zur Kenntnis, dass Sie sich strafbar machen, wenn Sie nicht der vorgesehenen Empfänger sind und diese Informationen trotzdem kopieren oder weiterleiten. Wenn Sie diese Informationen irrtümlich erhalten haben, benachrichtigen Sie bitte umgehend den Absender und löschen Sie die Informationen.

Ce message ne doit être utilisé que par les gens à qui il a été adressé. Il peut contenir des informations confidentielles et personnelles. Si vous n'êtes pas le destinataire prévu, il vous est, par la présente, notifié que toute dissémination, distribution ou copie de cette communication est strictement interdite. Si vous l'avez reçue par erreur, vous êtes prié de nous l'annoncer immédiatement et de la supprimer.

This message is intended only for the use of the individuals to whom it is adressed and may contain information that is privileged and confidential. If you are not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately and delete it.

eouia commented 4 months ago

Updated. Try it.

1Cedric1 commented 4 months ago

OK, thank you, I will try tomorrow, as I am not at home today.

can you please confirm

Thank you in advance and have a good day!

On Fri, 28 Jun 2024 at 09:32, Seongnoh Sean Yi < @.***> wrote:

Updated. Try it. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID:

DuckDuckGo removed one tracker. More https://duckduckgo.com/-hGysyZFupsqvAi0nzhKiHW-qw9G2uqfyELDp84KTA5zd1U_TN_jyVsbZlWTQmFmHRBnpOpMACxODfrRVk4CEIcplt789umQ1cm2kxoGstORhWamayqp3wXBSg0GTFQUBggQwk-LqmxQk06Eu2cGMAYJIsdicJMgsHd0_7w8t9hTzVP2Il2OP95dxHqnQepxjXOu9yJG_5Anv6hD19yd00f4ikHQelADU1xheJkXU74bv32Q_-7hf0Rui7wyRPGdRDbe2huby8tDuXhW_RLsxJF1GSAXh-xy_AIVqE4U5LjClUcOk45DruA3myEJdpEkoedPIgeWnHOBZmyliVFzNSaQBDM7SUtak0VFU698itOKWcsf8Cr6QovD9Moiqbz46YWWQyeu8Ess9Q3xUpb76Ihlu8t8Vv1cF5XmTKxzPzy9EBjst2FEtsMI2yN8j6ga_RWcFSu02nJf766hS4HhfSBQOWh2Lh09-_giT1y_Qd5UdcmJwqWnxV4iqMIW4yBx0 Report Spam https://duckduckgo.com/-hGysyZFupsqvAi0nzhKiHW-qw9G2uqfyELDp84KTA5zd1U_TN_jyVsbZlWTQmFmHRBnpOpMACxODfrRVk4CEIcplt789umQ1cm2kxoGstORhWamayqp3wXBSg0GTFQUBggQwk-LqmxQk06Eu2cGMAYJIsdicJMgsHd0_7w8t9hTzVP2Il2OP95dxHqnQepxjXOu9yJG_5Anv6hD19yd00f4ikHQelADU1xheJkXU74bv32Q_-7hf0Rui7wyRPGdRDbe2huby8tDuXhW_RLsxJF1GSAXh-xy_AIVqE4U5LjClUcOk45DruA3myEJdpEkoedPIgeWnHOBZmyliVFzNSaQBDM7SUtak0VFU698itOKWcsf8Cr6QovD9Moiqbz46YWWQyeu8Ess9Q3xUpb76Ihlu8t8Vv1cF5XmTKxzPzy9EBjst2FEtsMI2yN8j6ga_RWcFSu02nJf766hS4HhfSBQOWh2Lh09-_giT1y_Qd5UdcmJwqWnxV4iqMIW4yBx0

Updated. Try it.

— Reply to this email directly, view it on GitHub https://github.com/MMRIZE/MMM-anotherNewsFeed/issues/2#issuecomment-2196316673, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOV2OXVMNNXHATPIGQCR3PLZJUGSPAVCNFSM6AAAAABJ3TMOO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJWGMYTMNRXGM . You are receiving this because you modified the open/close state.Message ID: @.***>

--

Diese Mitteilung ist nur für den adressierten Empfänger bestimmt. Sie kann persönliche und vertrauliche Informationen enthalten. Nehmen Sie zur Kenntnis, dass Sie sich strafbar machen, wenn Sie nicht der vorgesehenen Empfänger sind und diese Informationen trotzdem kopieren oder weiterleiten. Wenn Sie diese Informationen irrtümlich erhalten haben, benachrichtigen Sie bitte umgehend den Absender und löschen Sie die Informationen.

Ce message ne doit être utilisé que par les gens à qui il a été adressé. Il peut contenir des informations confidentielles et personnelles. Si vous n'êtes pas le destinataire prévu, il vous est, par la présente, notifié que toute dissémination, distribution ou copie de cette communication est strictement interdite. Si vous l'avez reçue par erreur, vous êtes prié de nous l'annoncer immédiatement et de la supprimer.

This message is intended only for the use of the individuals to whom it is adressed and may contain information that is privileged and confidential. If you are not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately and delete it.

eouia commented 4 months ago
1Cedric1 commented 4 months ago

Hello

I could try, by re-installing your module without any problem. Thanks a lot.

On the other hand, the new version of your modules now causes a crash of the mirror, which do not start anymore.

When I erase your module, it is working well again.

Here the node and npm version I use ~ $ node -v v20.15.0 ~ $ npm -v 10.8.1

and here you may see the error.log

[1392:0629/112915.259885:ERROR:connection.cc(61)] X connection error received. /home/pi/MagicMirror/node_modules/electron/dist/electron exited with signal SIGTRAP [2024-06-29 11:29:38.570] [ERROR] (node:804) UnhandledPromiseRejectionWarning: Error: Cannot find module 'node-fetch' Require stack:

do you maybe see the bug?

On Fri, 28 Jun 2024 at 14:59, Seongnoh Sean Yi < @.***> wrote:

You should update the module. (Reinstall or git pull & npm update) I tested all 4 feeds. " https://partner-feeds.20min.ch/rss/20minutes/suisse-romande" " https://partner-feeds.lematin.ch/rss/lematin/mon DuckDuckGo removed one tracker. More https://duckduckgo.com/-hGysyZFupsqvAi0nzhKiHW-qw9F3OqfyEDDri9lMOnN__f_NFM-t4Kr3bGNuyLBoTi7BoA-UJFNgHxG9uTSEDH4GfZTZ2d7NfZoPAZloMWFhLDoaVmpmsaSe89Q5QaLLiIBBggQgkRLqmxQk0WAk25wEDJslid4uAHBw8O-07l_v6eKt_bB9q42z35tLCuJNltJ5ulW_HXFML4d6ZHr9kCn721lCPEWOA7-6EWt4uMvSCvYQ1It1ChtER3gIsVN-JD_h6r_h5N_r28ryWBeMs4xDgnWQAnnv8BWqQLQxPWmBMo6ClUch13AfeoSEjTULJoxwuYEs7oliYKWNVXsxQp-EfTuKWsjaVhqpKZx4cxSmmhPwXuIIkvD-VqCubj46Y3ZdJ7MjxxVwXY85eYbu_-XZ_1bpx_xlIKaPF60HUD0cHZFy2o1hiQ9Io85_1A1-jc4Lh7PH1ZOtbsXqtFiY6CgEsT8Eion__CpI0KtN3dB9xYWuqaPFViasQQXLCHHQ Report Spam https://duckduckgo.com/-hGysyZFupsqvAi0nzhKiHW-qw9F3OqfyEDDri9lMOnN__f_NFM-t4Kr3bGNuyLBoTi7BoA-UJFNgHxG9uTSEDH4GfZTZ2d7NfZoPAZloMWFhLDoaVmpmsaSe89Q5QaLLiIBBggQgkRLqmxQk0WAk25wEDJslid4uAHBw8O-07l_v6eKt_bB9q42z35tLCuJNltJ5ulW_HXFML4d6ZHr9kCn721lCPEWOA7-6EWt4uMvSCvYQ1It1ChtER3gIsVN-JD_h6r_h5N_r28ryWBeMs4xDgnWQAnnv8BWqQLQxPWmBMo6ClUch13AfeoSEjTULJoxwuYEs7oliYKWNVXsxQp-EfTuKWsjaVhqpKZx4cxSmmhPwXuIIkvD-VqCubj46Y3ZdJ7MjxxVwXY85eYbu_-XZ_1bpx_xlIKaPF60HUD0cHZFy2o1hiQ9Io85_1A1-jc4Lh7PH1ZOtbsXqtFiY6CgEsT8Eion__CpI0KtN3dB9xYWuqaPFViasQQXLCHHQ

Both feeds have images in the feed article as enclosure element, but have no file extension(For example, .jpg). The original code needs the file extension to confirm images, so I fix it.

— Reply to this email directly, view it on GitHub https://github.com/MMRIZE/MMM-anotherNewsFeed/issues/2#issuecomment-2196849201, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOV2OXT24N5BB5SPMSVA5BLZJVM37AVCNFSM6AAAAABJ3TMOO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJWHA2DSMRQGE . You are receiving this because you modified the open/close state.Message ID: @.***>

--

Diese Mitteilung ist nur für den adressierten Empfänger bestimmt. Sie kann persönliche und vertrauliche Informationen enthalten. Nehmen Sie zur Kenntnis, dass Sie sich strafbar machen, wenn Sie nicht der vorgesehenen Empfänger sind und diese Informationen trotzdem kopieren oder weiterleiten. Wenn Sie diese Informationen irrtümlich erhalten haben, benachrichtigen Sie bitte umgehend den Absender und löschen Sie die Informationen.

Ce message ne doit être utilisé que par les gens à qui il a été adressé. Il peut contenir des informations confidentielles et personnelles. Si vous n'êtes pas le destinataire prévu, il vous est, par la présente, notifié que toute dissémination, distribution ou copie de cette communication est strictement interdite. Si vous l'avez reçue par erreur, vous êtes prié de nous l'annoncer immédiatement et de la supprimer.

This message is intended only for the use of the individuals to whom it is adressed and may contain information that is privileged and confidential. If you are not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately and delete it.

eouia commented 4 months ago

This module was forked from the original newsfeed module a few years ago. Recently, the original MM changed its dependency to node-fetch. Instead, MM is using just built-in fetch now. The easiest way for you might be just installing node-fetch at the root directory of your MM.

cd <MagicMirror Directory>
npm install --save `node-fetch`

However, that is easy but not the standard way. It will cause the same problem later again (at next update).

So, I modified MMM-anotherNewsFeed to be compatible with the current recent MM. I dropped old node-fetch dependency and use fetch like the original module.

Try to reinstall or update the module.

1Cedric1 commented 4 months ago

Hello

excellent, it works now, you are a real genius!

in the .pm2/logs/mm-error.log file, I still find this error, not currently causing a problem, but maybe it can help you for maintaining your module.

Wishing you all the best, and one more time, congratulation for your work!

Cédric

[2024-07-01 14:39:29.469] [ERROR] GitError: fatal: detected dubious ownership in repository at '/home/pi/MagicMirror/modules/MMM-anotherNewsFeed'To add an exception for this directory, call: git config --global --add safe.directory /home/pi/MagicMirror/modules/MMM-anotherNewsFeed at Object.action (/home/pi/MagicMirror/modules/MMM-Remote-Control/node_modules/simple-git/dist/cjs/index.js:1451:25) at PluginStore.exec (/home/pi/MagicMirror/modules/MMM-Remote-Control/node_modules/simple-git/dist/cjs/index.js:1500:29) at /home/pi/MagicMirror/modules/MMM-Remote-Control/node_modules/simple-git/dist/cjs/index.js:1927:43 at new Promise () at GitExecutorChain.handleTaskData (/home/pi/MagicMirror/modules/MMM-Remote-Control/node_modules/simple-git/dist/cjs/index.js:1925:16) at GitExecutorChain. (/home/pi/MagicMirror/modules/MMM-Remote-Control/node_modules/simple-git/dist/cjs/index.js:1909:44) at Generator.next () at fulfilled (/home/pi/MagicMirror/modules/MMM-Remote-Control/node_modules/simple-git/dist/cjs/index.js:52:24) { task: { commands: [ 'remote', '-v' ], format: 'utf-8', parser: [Function: parseGetRemotesVerbose] }}

On Mon, 1 Jul 2024 at 14:01, Seongnoh Sean Yi < @.***> wrote:

This module was forked from the original newsfeed module a few years ago. Recently, the original MM changed its dependency to node-fetch. Instead, MM is using just built-in fetch now. The easiest way DuckDuckGo removed one tracker. More https://duckduckgo.com/-hGysyZFupsqvAi0nzhKiHW-qw9F2bqnyFfCC4ZLPX-U7dFM2s81TG2pZl0ZhYhEUb6LkBHGCAGPy7NYUMPARBLrPtfe2W3sC1kRYDupaSg2GlZiar2grPBQEKTVYcBAQGyECAr3NanECDvngLMwYETJTF7iKBz8LO3cP-8GJfIW_1j76BH004RjxNjHIxVZVmaXapdpHHsWy36_SlW6FivYfOOULOtdwxeahPeFzLWcXW4MQw6UYHZJhboOtEwbXeNSrVkNpVqe_3LHsxx10ESQbgafkvwMFauOFOSowqRHDJOKQ67gN5vGCXcRJKHnT8wHkpxzhmZspYlRczqCSArhm2lLWpNFRVcu7hW3aKCMb_Bc64KJw_TKxKm88On1lEMnqPM2p31TK_LdG3etW_tMhqXwY5ISQsqgM-fznawXHYjmKJDaZe9gZJP_A1elZQ1M4zD9JvmnzsAzXfUBKCm547C5_-_hUkqV-67yg_4MLiVNDiqxJXYQxRkz7oAA Report Spam https://duckduckgo.com/-hGysyZFupsqvAi0nzhKiHW-qw9F2bqnyFfCC4ZLPX-U7dFM2s81TG2pZl0ZhYhEUb6LkBHGCAGPy7NYUMPARBLrPtfe2W3sC1kRYDupaSg2GlZiar2grPBQEKTVYcBAQGyECAr3NanECDvngLMwYETJTF7iKBz8LO3cP-8GJfIW_1j76BH004RjxNjHIxVZVmaXapdpHHsWy36_SlW6FivYfOOULOtdwxeahPeFzLWcXW4MQw6UYHZJhboOtEwbXeNSrVkNpVqe_3LHsxx10ESQbgafkvwMFauOFOSowqRHDJOKQ67gN5vGCXcRJKHnT8wHkpxzhmZspYlRczqCSArhm2lLWpNFRVcu7hW3aKCMb_Bc64KJw_TKxKm88On1lEMnqPM2p31TK_LdG3etW_tMhqXwY5ISQsqgM-fznawXHYjmKJDaZe9gZJP_A1elZQ1M4zD9JvmnzsAzXfUBKCm547C5_-_hUkqV-67yg_4MLiVNDiqxJXYQxRkz7oAA

This module was forked from the original newsfeed module a few years ago. Recently, the original MM changed its dependency to node-fetch. Instead, MM is using just built-in fetch now. The easiest way for you might be just installing node-fetch at the root directory of your MM.

cd npm install --save node-fetch

However, that is easy but not the standard way. It will cause the same problem later again (at next update).

So, I modified MMM-anotherNewsFeed to be compatible with the current recent MM. I dropped old node-fetch dependency and use fetch like the original module.

Try to reinstall or update the module.

— Reply to this email directly, view it on GitHub https://github.com/MMRIZE/MMM-anotherNewsFeed/issues/2#issuecomment-2199958208, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOV2OXRFKF7XADEKKQKYJ3DZKFAJVAVCNFSM6AAAAABJ3TMOO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJZHE2TQMRQHA . You are receiving this because you modified the open/close state.Message ID: @.***>

--

Diese Mitteilung ist nur für den adressierten Empfänger bestimmt. Sie kann persönliche und vertrauliche Informationen enthalten. Nehmen Sie zur Kenntnis, dass Sie sich strafbar machen, wenn Sie nicht der vorgesehenen Empfänger sind und diese Informationen trotzdem kopieren oder weiterleiten. Wenn Sie diese Informationen irrtümlich erhalten haben, benachrichtigen Sie bitte umgehend den Absender und löschen Sie die Informationen.

Ce message ne doit être utilisé que par les gens à qui il a été adressé. Il peut contenir des informations confidentielles et personnelles. Si vous n'êtes pas le destinataire prévu, il vous est, par la présente, notifié que toute dissémination, distribution ou copie de cette communication est strictement interdite. Si vous l'avez reçue par erreur, vous êtes prié de nous l'annoncer immédiatement et de la supprimer.

This message is intended only for the use of the individuals to whom it is adressed and may contain information that is privileged and confidential. If you are not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately and delete it.

eouia commented 4 months ago

That error is not important. (I changed ownership of this module from my old id eouia to MMRIZE. That might cause that error.) Or you can resolve it by removing and reinstalling (MMRIZE/MMM-anotherNewsFeed instead of eouia/MMM-anotherNewsFeed)