Open MMhaidari opened 1 year ago
Hi @MMhaidari, @Rana-Mudassir and @LoviMadaan,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
Kanban board link https://github.com/MMhaidari/rails-group-capstone/projects/1
Hi Team,
Good job so far, indeed you have spent time on this project! There are some issues that you still need to work on to go to the next project but you are almost there!
Check the comments under the review.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
N+1 quires problem is already added to the Group-Task [1pt] General shopping list view. Group Task
Hi Team,
Your project is complete! There is nothing else to say other than... it's time to merge it: ship it: Congratulations! 🎉
✅ Set up Kanban Board correctly 👍🏽 ✅ Tasks are shared fairly 👍🏽 ✅ Added description for all tasks 👍🏽
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Project GitHub link https://github.com/MMhaidari/rails-group-capstone/projects/1
note: there are three people in the group TEAM MEMBER 1: @LoviMadaan TEAM MEMBER 2: @Rana-Mudassir TEAM MEMBER 3: @MMhaidari