search

MNGuenther / allesfitter

allesfitter is a convenient wrapper around the packages ellc (light curve and RV models), dynesty (static and dynamic nested sampling) emcee (Markov Chain Monte Carlo sampling) and celerite (Gaussian Process models).
MIT License
60 stars 36 forks source link

Small bug creating keys for baseline offsets (RV) #50

Closed mycojo closed 2 years ago

mycojo commented 2 years ago

Was trying to set RV offsets for an instrument and kept getting a key error, the key being created was using 'flux' instead of 'rv' in the string. Here's the error message:

Screen Shot 2022-03-13 at 5 24 35 PM

Did some poking around, looks like in lines 284, 288, and 289 of the 3rd section of Parameters, the string being created was defaulting to using 'flux' instead of looking at the key ('flux' or 'rv'). Here's what they looked like originally:

Screen Shot 2022-03-13 at 10 28 07 PM

It was an easy fix, I switched it to match the formatting of the above parameters and it works fine for me now. Here's what it looked like when I got it working:

Screen Shot 2022-03-13 at 10 29 29 PM

Not sure if this is just something I've experienced or if this is a wider issue, just letting you know!

MNGuenther commented 2 years ago

Ah fantastic, thanks a lot for finding this bug and already providing the solution, @mycojo! Will be fixed in the next GitHub push and pip-release asap!

Edit: Fixed now in v1.2.9.