search

MOARdV / DistantObject

Distant Object Enhancement bis plugin for Kerbal Space Program
51 stars 14 forks source link

FlareDraw refactoring #19

Closed MOARdV closed 8 years ago

MOARdV commented 9 years ago

Several issues that could be improved or outright redone:

a) scaledTransforms is searched every update for every world. These transforms should simply be cached away by their respective BodyFlare objects.

b) Might be able to do away with the planet color configs by importing the values from OrbitDriver (by way of Planetarium.fetch.orbits). Provided add-on orbits set these colors, that is. A couple of alternatives - look at atmosphere color, and look at seeing if there's a way to get a value from the planet renderer in ScaledSpace?

c) Don't apply dimFactor to alpha - instead, pre-multiply the color (and cache the color in the BodyFlare / use white for the VesselFlare), so only atmosphere affects alpha.

d) Figure out what can be moved to FixedUpdate, instead of leaving it in Update.

MOARdV commented 8 years ago

a) is done. b) I think I will skip (to allow end-users to continue to customize colors as they see fit). c) is the last one to do - maybe related to Issue #25 ? d) is done.

MOARdV commented 8 years ago

Applied c) during the tweaks to saturation.