search

MPAS-Dev / MPAS-Model

Repository for MPAS models and shared framework releases.
235 stars 312 forks source link

Add mpas_dmpar_sum_int8 to mpas_dmpar #1127

Closed dimomatt closed 9 months ago

dimomatt commented 9 months ago

This PR adds a function to sum the values of an 8-byte integer across all MPI ranks. It is functionally identical to mpas_dmpar_sum_int, but returns an integer(kind=I8KIND) instead of a standard 4-byte integer.

mgduda commented 9 months ago

I ended up writing a few tests for the new mpas_dmpar_sum_int8 routine that I turned into tests in the test core. Would it be fine if I pushed a additional commit to this PR branch to include those tests?

dimomatt commented 9 months ago

yes, that sounds good!

mgduda commented 9 months ago

yes, that sounds good!

I've just pushed another commit with a couple of tests. If all looks good to you, I think we're ready to merge.

dimomatt commented 9 months ago

Tests all look good and pass with the intel compiler- I am happy to have this merged