search

MPAS-Dev / MPAS-Model

Repository for MPAS models and shared framework releases.
235 stars 312 forks source link

Initialize `mvd_r` and `mvd_c` before first use in Thompson microphysics scheme #1152

Closed mgduda closed 5 months ago

mgduda commented 5 months ago

This PR initializes two local variables, mvd_r and mvd_c, in the mp_thompson routine to avoid the potential use of uninitialized memory.

Note: Identical changes to those included in this PR have separately been introduced into newer versions of the Thompson microphysics scheme, and so the changes here can be considered a back-port of these fixes.

mgduda commented 5 months ago

The changes in this PR fix Issue #1150.

ldfowler58 commented 5 months ago

I completely agree with the description of the added initializations and approve this PR.