search

MUCollective / pgog

Supplemental to A Probabilistic Grammar of Graphics
14 stars 1 forks source link

Refine the divider function #64

Closed xiaoyingpu closed 4 years ago

xiaoyingpu commented 4 years ago

https://github.com/MUCollective/pgog/blob/83adcdae3070dd5df41cf5306ce3ddcf67264da6/R/divider.R#L2-L16

This case statement is not complete. Need to decide whether to leave out fill and color aesthetics or write out all the combinations.

Also related to parsing.

Throw out these before calling swtich

and consider the ordering of aesthetics, like x.height and height.x are the same

nanyyyyyy commented 4 years ago

Use if statement to check the aes, if find the listed above aes. return null

nanyyyyyy commented 4 years ago

is that ok if e.g colour.x.width being evaluated as x.width

xiaoyingpu commented 4 years ago

Yes that’s the idea

On Sat, Feb 8, 2020 at 00:07 olivernan notifications@github.com wrote:

is that ok if e.g colour.x.width being evaluated as x.width

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/MUCollective/pgog/issues/64?email_source=notifications&email_token=AB74SLMTNO4P53WQOIB6EL3RBY4XPA5CNFSM4KFLMGR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELFJZDY#issuecomment-583703695, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB74SLPBX3ICPAQYRM5GJ3DRBY4XPANCNFSM4KFLMGRQ .

-- Xiaoying Pu Ph.D. Candidate in Computer Science and Engineering University of Michigan xiaoyingpu.github.io Midwest Uncertainty Collective https://mucollective.northwestern.edu

nanyyyyyy commented 4 years ago

Yes that’s the idea On Sat, Feb 8, 2020 at 00:07 olivernan @.***> wrote: is that ok if e.g colour.x.width being evaluated as x.width — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#64?email_source=notifications&email_token=AB74SLMTNO4P53WQOIB6EL3RBY4XPA5CNFSM4KFLMGR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELFJZDY#issuecomment-583703695>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB74SLPBX3ICPAQYRM5GJ3DRBY4XPANCNFSM4KFLMGRQ . -- Xiaoying Pu Ph.D. Candidate in Computer Science and Engineering University of Michigan xiaoyingpu.github.io Midwest Uncertainty Collective https://mucollective.northwestern.edu

Can you review my pull request?