Parser fixes - Githubissues

mjskay commented 4 years ago

This:

renames pprint to print.prob_chain (and sets a prob_chain class on results of parse_aes()) to make it easier to inspect parse_aes results
fixes the spec parser so top-level functions are not stripped, allowing you to omit c() on prob expressions with only one pmf.

mjskay commented 4 years ago

Hmm, with the travis failure I will have to look into problems in pgog.Rmd and create some tests that reproduce those problems (then fix them) before we merge this. Don't merge for now.

xiaoyingpu commented 4 years ago

oh i'm fixing it already

On Sat, Jan 25, 2020 at 12:48 PM Matthew Kay notifications@github.com wrote:

Hmm, with the travis failure I will have to look into problems in pgog.Rmd and create some tests that reproduce those problems (then fix them) before we merge this. Don't merge for now.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/MUCollective/pgog/pull/81?email_source=notifications&email_token=AB74SLMLXRL5647VFYZLJ3LQ7R3PTA5CNFSM4KLL46E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ5BQ2Y#issuecomment-578426987, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB74SLPMU5QQ7YO7OY6DNTLQ7R3PTANCNFSM4KLL46EQ .

-- Xiaoying Pu Ph.D. Candidate in Computer Science and Engineering University of Michigan xiaoyingpu.github.io Midwest Uncertainty Collective https://mucollective.northwestern.edu

mjskay commented 4 years ago

Awesome! 🙂

MUCollective / pgog

Parser fixes #81