Fixed JoL unit tests: removed fail reduce option test, adjusted fail …

MUnique / OpenMU

This project aims to create an easy to use, extendable and customizable server for a MMORPG called "MU Online".

https://munique.net

MIT License

743 stars 326 forks source link

Fixed JoL unit tests: removed fail reduce option test, adjusted fail … #537

Closed ze-dom closed 5 days ago

ze-dom commented 5 days ago

…remove option test

sven-n commented 5 days ago

I had assumed the test was correct, but the game logic is not. However, I couldn't find a reliable source where it wasn't set to 0... so I accept this PR 😅

sven-n commented 5 days ago

Thank you for the quick fix

ze-dom commented 5 days ago

JoL failed upgraded was fixed on PR#501. Besides the reference mentioned there, check here and this video from official global channel (min 2:08): https://www.youtube.com/watch?v=gD5o6YOXCZ8

Anything I propose, I am happy to (and think one should) provide references :smile: I played Seasons I and II and I don't remember ever JoL option dropping 1 level. Possibly you got this info from the official website, but I challenge you to find any video (from an official server) to back this up.