search

MabezDev / ssd1351

A Driver crate for the SSD1351, which drives 128x128 colour displays
16 stars 14 forks source link

Implement fill_contiguous only when unbuffered #20

Closed DerFetzer closed 8 months ago

DerFetzer commented 9 months ago

fill_contiguous only makes sense when using the unbuffered version.

When using the implementation in this crate with the buffered flag the buffer is not even used and the display is updated directly. This means following calls to flush will erase the drawn areas.

Orange-Murker commented 8 months ago

Thank you for the PR. Tested it and it indeed seems to use fill_contiguous directly instead of writing to the buffer. Makes sense.

Orange-Murker commented 8 months ago

Would it make sense to drop support for buffering in this crate and point people to https://crates.io/crates/embedded-graphics-framebuf instead?

DerFetzer commented 8 months ago

Thanks for merging! I've never used that crate before but if it does what it claims to do it should be a good replacement for all the various individual framebuffer implementations out there.