search

MacPass / KeePassKit

KeePass Database loading, storing and manipulation framework
Other
125 stars 40 forks source link

KPKCompositeKey conforms to NSCoding protocol #50

Closed juliuszint closed 4 years ago

juliuszint commented 4 years ago

This implements your suggestion from #1089 and makes KPKCompositeKey conform to NSCoding protocol. With this change the TouchID unlock feature works with Keyfiles.

I forked from the 2.4.7 tag since this is the version that is currently used by MacPass and there are commits in KeePassKit that contain breaking changes.

mstarke commented 4 years ago

If you are ok with it, I'm going to let this PR sit here without merging and will try to add NSCoding or to be more precise NSSecureCoding to KPKCompositeKey in the current version. I did not push the current code of MacPass that already has changes to work with the different API. We then should try to port those changes for TouchID on MacPass to the new code base as well.

juliuszint commented 4 years ago

Sounds good. The changes that were made are very small anyway. If you need help with anything let me know.

mstarke commented 4 years ago

code now includes NSSecureCoding support as of 34a84a48f51c4d49d3f7f8c814080ceec4a03a8b