search

Macchina-CLI / macchina

A system information frontend with an emphasis on performance.
https://crates.io/crates/macchina
MIT License
1.49k stars 52 forks source link

[BUG] windows version reports invalid theme for provided themes #224

Closed bw1faeh0 closed 3 years ago

bw1faeh0 commented 3 years ago

Describe the bug The current windows version of macchina is not able to use the themes provided by this repo

To Reproduce Steps to reproduce the behavior:

  1. download Hydrogen.toml and save as D:\Programme\macchina\themes\Hydrogen.toml
  2. run macchina-windows-x86_64 -t D:\Programme\macchina\themes\Hydrogen.toml

Expected behavior macchina uses the theme

Screenshots image

image

macchina --doctor output

Let's check your system for errors... Here's a summary:

We've collected 18 readouts, including 2 failed read(s) and 8 read(s) which resulted in a warning.
Readout "Packages" failed with message: No packages found — Do you have a package manager installed?
Readout "LocalIP" failed with message: Unable to get local IP address.

8 of the 10 unsuccessful read(s) resulted in a warning:
Readout "Distribution" threw a warning with message: This metric is not available on this platform or is not yet implemented by Macchina.
Readout "DesktopEnvironment" threw a warning with message: This metric is not available on this platform or is not yet implemented by Macchina.
Readout "WindowManager" threw a warning with message: This metric is not available on this platform or is not yet implemented by Macchina.
Readout "Terminal" threw a warning with message: This metric is not available on this platform or is not yet implemented by Macchina.
Readout "Shell" threw a warning with message: This metric is not available on this platform or is not yet implemented by Macchina.
Readout "Resolution" threw a warning with message: This metric is not available on this platform or is not yet implemented by Macchina.
Readout "Backlight" threw a warning with message: This metric is not available on this platform or is not yet implemented by Macchina.
Readout "ProcessorLoad" threw a warning with message: This metric is not available on this platform or is not yet implemented by Macchina.

System Information macchina 5.0.5

grtcdr commented 3 years ago

Hi,

This is an issue of misplaced themes, can you place them in {FOLDERID_RoamingAppData}/macchina/themes?

That should be %AppData%/macchina/themes if I'm not mistaken.

bw1faeh0 commented 3 years ago

I'll try this as soon as possible, but if this is the reason, it should be mentioned in the documentary that this dir is hard coded.

I read the documentary about this but was not able to "translate" FOLDER_ID in a valid windows path.

I assumed that by using the -t switch I'm able to use any file specified by the path I provide.

grtcdr commented 3 years ago

I hate to be the "read the readme" guy, but the README covers exactly how to configure and customize (two different procedures) macchina.

We'll go over the flags once again and be even more specific to avoid ambiguity :)

bw1faeh0 commented 3 years ago

Ok, I created %AppData%/macchina (which is AppData\Roaming\macchina) and put my files in there (themes in subdir themes). Now it works.

You should add to your readme, that {FOLDERID_RoamingAppData} (which I never read before and what me made fail initially) means %AppData%.

Thanks for clarification!

grtcdr commented 3 years ago

You should add to your readme, that {FOLDERID_RoamingAppData} (which I never read before and what me made fail initially) means %AppData%.

Will do.

EDIT: done https://github.com/Macchina-CLI/macchina/commit/25dc51dcbf7836c566ef2803ba46a8b5ca52e168.

Thanks for clarification!

You're welcome, your feedback has been very helpful, so thank you! :rocket: