search

Macchina-CLI / macchina

A system information frontend with an emphasis on performance.
https://crates.io/crates/macchina
MIT License
1.49k stars 52 forks source link

"Could not locate the configuration file" prints on every run #246

Closed 414owen closed 2 years ago

414owen commented 2 years ago

This seems to be have been introduced between versions 5.0.5 and 6.0.1.

./result/bin/macchina
Error: Custom { kind: NotFound, error: "Could not locate the configuration file" }

        a8888b.           Host        -  owen@nixos
       d888888b.          Machine     -  Dell Inc. XPS 13 9370
 ...

I personally didn't plan on writing a macchina config file, but I don't want that to print on every run.

It's not strictly a bug, but I'm not a fan of this default behavior. It says there's an error, yet it continues running just fine. Maybe this should only be printed when running the doctor (-d)?

Found this change while reviewing the nixpkgs upgrade pr

grtcdr commented 2 years ago

We're tackling this in v6.0.2.

I'm closing this as it's a duplicate of #242

grtcdr commented 2 years ago

@414owen Is this still an issue with v6.0.2?

EDIT: Yes...

EDIT 2: Fixed with v6.0.3