Macchina-CLI / macchina

A system information frontend with an emphasis on performance.
https://crates.io/crates/macchina
MIT License
1.49k stars 52 forks source link

Add gpu readout #278

Closed Rolv-Apneseth closed 1 year ago

Rolv-Apneseth commented 1 year ago

In relation to #107.

Add the ability to display connected GPUs with the readout information provided by libmacchina v6.4.0, added in this PR. This functionality is currently only implemented for Linux.

Rolv-Apneseth commented 1 year ago

Not sure what's causing that Android error:

clang90: error: linker command failed with exit code 1 (use -v to see invocation)

What's the best way to go about trying to diagnose / fix this?

grtcdr commented 1 year ago

Huh, I thought I fixed this in https://github.com/Macchina-CLI/libmacchina/commit/d5077cd821e6ae7533525dc7b6a4d027088197e7 as @Gobidev suggested in https://github.com/Macchina-CLI/libmacchina/pull/142.

Gobidev commented 1 year ago

@grtcdr I also got very confused there for a second😅 We only fixed this in libmacchina, macchina has the same problem. I made a PR: #280

Gobidev commented 1 year ago

@Rolv-Apneseth rebasing with upstream will fix the failing Android build

Rolv-Apneseth commented 1 year ago

@Rolv-Apneseth rebasing with upstream will fix the failing Android build

Nice, thank you

grtcdr commented 1 year ago

Thanks a lot for working on this, Rolv.

Rolv-Apneseth commented 1 year ago

No worries, thanks for this awesome tool