search

Macchina-CLI / macchina

A system information frontend with an emphasis on performance.
https://crates.io/crates/macchina
MIT License
1.24k stars 47 forks source link

Possible improvement to memory readout #282

Closed Rolv-Apneseth closed 1 year ago

Rolv-Apneseth commented 1 year ago

Just a possible suggestion, but for the memory readout, could I 1. add spaces around the / and 2. add the option to show a % next to the numbers, i.e. current:

14.9 GB/32.8 GB

suggestion:

14.9 GB / 32.8 GB (45%)
grtcdr commented 1 year ago

The format is hardcoded, unfortunately. I'll work on adding the option and the much needed spacing.

Rolv-Apneseth commented 1 year ago

Nice! If you're busy and would prefer me to work on it that's fine too. As an aside the same should probably be done for available disk space whenever that feature is added. What is missing for that to be implemented by the way?

grtcdr commented 1 year ago

I added the feature in c05d59185c81db71fee32e45aa9b8d01082bbf5d.

What is missing for that to be implemented by the way?

Eh, nothing in particular. It should've been added into macchina long ago.

Rolv-Apneseth commented 1 year ago

I added the feature in c05d591.

Nice. Does it need some documentation / to be added to the macchina.toml file?

Eh, nothing in particular. It should've been added into macchina long ago.

Oh nice. Is it implemented in libmacchina and just needs to be added here? I can have a look at it.

grtcdr commented 1 year ago

I added the feature in c05d591.

Nice. Does it need some documentation / to be added to the macchina.toml file?

It does. Thanks for reminding me!

Eh, nothing in particular. It should've been added into macchina long ago.

Oh nice. Is it implemented in libmacchina and just needs to be added here? I can have a look at it.

Yes, there's an implementation for all *nix platforms.

Rolv-Apneseth commented 1 year ago

Nice well I'll have a look at that hopefully during this week then, and thanks for implementing the changes to the memory readout