Webinar delete failed issue fix.

MacsiDigital / laravel-zoom

Laravel Zoom Package

MIT License

261 stars 135 forks source link

Webinar delete failed issue fix. #99

Closed PasanBhanu closed 3 years ago

PasanBhanu commented 3 years ago

I got this error when implementing webinars through my laravel application.

Too few arguments to function MacsiDigital\API\Support\ApiResource::beforeDeleting(), 0 passed in C:\xampp\htdocs\website\vendor\macsidigital\laravel-api-client\src\Traits\InteractsWithAPI.php on line 528 and exactly 1 expected

I fixed the issue by adding delete function (Taken from Meeting model)

Laravel Version : 7

PasanBhanu commented 3 years ago

Hi, Please check why the test failed. I only added one function and also I tested it in my live website.

colinhall17 commented 3 years ago

Hi @PasanBhanu

Thanks for reaching out and creating the PR.

The issue is not actually with this function but a related function in the underlying API library repo. Of course, your fix will work as it overrides the underlying delete function from the API library. However the best thing to do is fix the issue on the API library, which I have now done.

If you update your dependencies and make sure that MacsiDigital/laravel-api-client is version 3.3.5

Thanks again, I will now close down this PR