search

MadProbe / Yapped-Rune-Bear

Even more personal version of Yapped for Elden Ring
7 stars 1 forks source link

Elden Ring 1.10 - Saved file always get corrupted #3

Open LeGrosWinnie opened 9 months ago

LeGrosWinnie commented 9 months ago

Hello, After I modify a regulation.bin file and saved it, the file size is increased and I cannot open it anymore.

https://i.ibb.co/FbX41mr/image.png https://i.ibb.co/R3ZWqTk/image.png

I don't understand how the tool can work for anyone...

Thanks.

MadProbe commented 9 months ago

Can I ask you to send me the regulation.bin file for testing?

LeGrosWinnie commented 9 months ago

As you can see the dead one is larger and... not working of course. So, open the working one, save directly without doing anything and just restart Yapped (as it will auto open the last file used).

I guess there is some issue with the encryption key so that the encrypted file cannot be opened anymore in some situation (all situation in my case).

Workign one (backup from a working backup).zip Dead one (the backup of the currently modded version).zip

MadProbe commented 9 months ago

Hmm, after some bug hunting I didn't have the exact error you have, but I had another error and I fixed it (hopefully). Could you try out this fix and tell me if it even did anything?

MadProbe commented 9 months ago

@LeGrosWinnie Could you confirm this? I want to inform you that 2 days from the moment the comment is posted the issue would be closed if you won't reply as I will interpret silence as confirmation

LeGrosWinnie commented 9 months ago

I will test it today (UCT+2). I was busy the whole week-end sorry.

LeGrosWinnie commented 9 months ago

Better for the case I had. But now, if you do that in this order :

  1. Open and save a file
  2. Exit
  3. Launch (should open the last opened file)
  4. Manually open the same file or open another file and immediatly reopen the other file (the autoloaded one)
  5. Crash, but you can stil "Ignore" the dialog.
  6. Now you have this issue, exit and relaunch, then open the same opened file and you get the error.

https://i.ibb.co/K9rqDHW/image.png image

If I open with the original tool version : image If I try the same kind of ""brute" test with this version it still worked.

Perhaps there is a stream/writer somewhere not properly closed ? I mean the error is about reading bytes with not corresponding space.

I did another test : Launch Open a "new" file Exit Launch Exit Launch Not I cannot launch it anymore at all... XD If I rename the exe file I can open it... Something linked to dependices perhaps ? There is no "y" process running but I don't know if there are "forks" running in background.

Okay there is clearly an issue in the saving process. If you save close the popup and directly exit the program (which should be ok as the popup is close it means there is no threads running ?). Then you cannot launch the app anymore... But now I can rename the file back to the original name and run it again, and if I go quick it says the trace.log file is in use...

Sorry about all of that, I work as a soft engineer so... :-)

MadProbe commented 9 months ago

So, I have made a new version, now for this time I think it should be pretty much stable and it should have quite fewer bugs than the older version I have sent you. https://easyupload.io/lrwk97 I implore you to check it out and tell me if something's wrong.

LeGrosWinnie commented 9 months ago

Hello, Thanks I will look at it this afternoon (UTC+1 so in 6 hours starting from now).

LeGrosWinnie commented 9 months ago

Juste to be sure : backup file is only created if not exists ?

A nice feature should be to add a counter to the bak file. So if file exists : add 001 then 002 etc. Should not be hard to check (just cut the last 3 char of the file name, converte to int, if int < 0 then add 00 etc.

Otherwise it works fine for now.

Thanks again ! :-)

LeGrosWinnie commented 9 months ago

I forgot to ask (not related to the original issue) : can you add a "Reset" for the category ? If you remove the text and click Apply it crashes.

LeGrosWinnie commented 9 months ago

Okay, in fact there are still some bugs, I don't really undersand where. But if I import the 2 CSV linked, into the reg file and then open the file in original Yapped it crashes (still the size thing). And of course the game crashes. This is why I tested it in the other Yapped, to see what was happening.

ItemLotParam_map.zip regulation.bin.zip

MadProbe commented 9 months ago

The size difference doesn't do anything, since the default compression level in .NET 8 is Optimal, so it would obviously be bigger in size, but I have changed it to SmallestSize as I see that it bothers you, and in size it became ~= to the original reg.bin file.

LeGrosWinnie commented 9 months ago

The size thing is not the file size, it increased because I loaded the row name and it is stored inside the reg file.

The issue is that (after I juste open/save, no import or anything else) :

image

You can open the file with your version only and it makes the game crashes.

MadProbe commented 9 months ago

I have botched an explanation: The size difference just doesn't matter at all and is not connected in any way with the bug. Also I have fixed the stuff and now provided by you reg.bin now works in the original yapped rune bear after saving it in my version of yapped and could you test out this build?: https://easyupload.io/u3rbr5

LeGrosWinnie commented 9 months ago

Thanks, I will check that when I have time. Must go to work on site tomorrow so the day after tomorrow I will test it.

ZizzyZizzy commented 8 months ago

@MadProbe Uhh..WTF? Original did not get flagged as a trojan. image

MadProbe commented 8 months ago

@ZizzyZizzy, I do not fucking know wtf does Windows Defender flags my app as malicious, you can see all the code in this repository and you can check all of the code out in this repository and there is also ManagedCodeShenanigans.dll which I made myself in dnSpyEx (as the code there cannot be represented in normal C#) and you can view the code by aforementioned IL code (dis)assembler. Also these are the settings I use to publish a single compact executable. image BTW, I had my stuff locked on nexusmods as one of the anti-viruses in VirusTotal.com (an aggregator of anti-viruses which has all of these check the suspected file) flagged my executable and I had to request manual review to unlock it. The support request: image Answer: image

LeGrosWinnie commented 8 months ago

I don't have the defender issue. Strange (Windows 11 23h2 up to date).

The 2.2.4.0 version is working fine.

Thanks for everything !

ZizzyZizzy commented 8 months ago

@MadProbe Very strange. I downloaded it just now in two different browsers and it works fine. Windows 10 did not flag it.

Either Windows had a false positive that was fixed, or EasyUpload did something sketchy to your download the first time.

LeGrosWinnie commented 8 months ago

In fact it is crashing again... I open a file, export CSV open another file import csv save run the game : crashes... open the file in original branch... crashing... image