MadeMyDay / PageTableExtended

Extends the Processwire PageTable field for rendering table row layouts.
15 stars 11 forks source link

"Table fields to display in admin" should not be required #4

Closed jordanlev closed 9 years ago

jordanlev commented 10 years ago

Hi, Thanks for this fantastic module. When I have the "Render layout instead of table rows" option checked, then it seems the "Table fields to display in admin" setting is not utilized (because it is using the template file instead). In fact, I can put in a fake field name (for example, "dummy") into that textarea and everything works just fine (even though there is no field named "dummy" in my site). However, if I leave that textarea blank, then when I go to edit a page with the PageTableExtended field in it, I get the error message "Please enter one or more columns in your field settings before using this field.". This error message should not appear in this situation because it is not true -- the column settings are ignored in this situation anyway so why would I have to specify them?

Thanks.

MadeMyDay commented 10 years ago

Thx for reporting. I have to take a look and prove if I can override the default behavior of PageTable. Since you deleted the standard (I think it's the title) entry for the rows I never encountered this error.

jordanlev commented 9 years ago

Oh, I see... that setting is part of the normal "PageTable" field, not specific to PageTableExtended.

I'm still new to ProcessWire so it's taking me a while to wrap my head around how this stuff works (although not as much as most other CMS's I've tried to learn over the years -- it's a relatively consistent and sane system).

Anyway, for my purposes this isn't a big deal because I can use the workaround mentioned above (just populating the setting with a dummy value).

Thanks!

jordanlev commented 9 years ago

closing issue because it has to do with the normal PageTable field (not PageTableExtended). Also it is easily resolved by putting the word "title" in there.