MagicMirrorOrg / MagicMirror

MagicMirror² is an open source modular smart mirror platform. With a growing list of installable modules, the MagicMirror² allows you to convert your hallway or bathroom mirror into your personal assistant.
http://magicmirror.builders
MIT License
19.76k stars 4.2k forks source link

Default calendar: nextDaysRelative not working #3603

Open evroom opened 2 hours ago

evroom commented 2 hours ago

Default calendar: the nextDaysRelative parameter seems to not work. The timeformat remains absolute for events on today and tomorrow.

$ grep version /home/admin/MagicMirror/package.json
    "version": "2.30.0-develop",
nextDaysRelative
If this is set to true, the appointments of today and tomorrow are displayed relatively,
even if the timeformat is set to absolute.

timeFormat: "absolute", nextDaysRelative: false,

nextDaysRelative_false

timeFormat: "absolute", nextDaysRelative: true,

nextDaysRelative_true
sdetweil commented 2 hours ago

can you post config please this is develop pulled down when? (just checking)

evroom commented 2 hours ago

Did the git pull on approx. Sat 26 Oct 10:45:00 CEST 2024.

config.js (removed personal entries):

config.js.txt

sdetweil commented 2 hours ago

nextDaysRelative is only for full day events AND timeFormat : "absolute" according to the code

you only showed duration events, not full day

evroom commented 2 hours ago

Okay, that is not mentioned in the documentation.

But indeed that is what it does:

nextDaysRelative_fullday_true
sdetweil commented 2 hours ago

i think its encoded in the name next DAYS relative

evroom commented 1 hour ago

For a Sherlock Holmes like you perhaps :-) It wasn't clear for a regular user like me. I read next days as today, tomorrow, day after tomorrow. The text narrowed this down to today and tomorrow.

Opened this anyway: https://github.com/MagicMirrorOrg/MagicMirror-Documentation/issues/267

Please close this issue (#3603) when it is meant to be for fullday events only. Otherwise the issue will address the fact that it is not working non-fullday events events.

sdetweil commented 1 hour ago

relative only matters for full day events

Saturday 16:00-18:00 displayed as Today and Sunday, 16:00-18:00 displayed as Tomorrow

seem illogical to me

go fishing w Bob, Oct 26 and spend the day w Sue, Oct 27

make me try to envision when those days are ( today is saturday, some day of the month)

Today and Tomorrow clear it up instantly