search

MagicStack / MagicPython

Cutting edge Python syntax highlighter for Sublime Text, Atom and Visual Studio Code. Used by GitHub to highlight your Python code!
MIT License
1.41k stars 91 forks source link

Discourage installation for ST4 users #255

Open FichteFoll opened 1 year ago

FichteFoll commented 1 year ago

The package is behind the default Python syntax in adopting new syntax features and in adhering to the scoping standards that the community has established for the default packages. It also has access to branching and can thus reliably detect whether a curly brace begins a set or a dict literal over multiple lines.
Besides, the latest update installable via Package Control has been released over 4 years ago because no tag has been pushed to the repo since and that is required for Package Control to pick up new versions.

2023-02-23_20-41-54

Thus, I propose to discourage installation for ST4 users. Users of older versions may still want to install it because their default packages won't receive any updates anymore. You should also push a new tag to the repo to allow installation of the latest changes for ST users of older versions.

FichteFoll commented 1 year ago

It would probably also be a good idea to outright disable installation of MagicPython for ST4 users altogether. I can quickly make that change if you agree to it, but I want to confirm this with you first as there may still be some reason that users would want to use MagicPython over the default that I don't know about.

FichteFoll commented 1 year ago

Bump.

FichteFoll commented 1 year ago

It would probably also be a good idea to outright disable installation of MagicPython for ST4 users altogether.

I've gone ahead and did that. We will probably merge it soon, although it can easily be reverted. However, I currently don't see any reason for it.

https://github.com/wbond/package_control_channel/pull/8841