rive-n
commented
2 years ago I found a solution, but that's really strange one...
Before of starting pool: executor.start_polling(bot_dispatcher, skip_updates=True) we need to configure Database object like this:
loop = get_event_loop()
db = Database(loop)
bot['db_pool'] = dbAnd Database object:
class Database(object):
def __init__(self, loop):
if environ.get('DEBUG'):
self.host, self.port, self.database = '127.0.0.1', 5432, 'test'
else:
self.host, self.port, self.database = environ.get('PG_HOST', 'postgres'), environ.get('PG_PORT', 5432), environ.get("PG_DATABASE")
self.pool = loop.run_until_complete(create_pool(
user = environ.get('PG_USERNAME'),
password = environ.get('PG_PASSWORD'),
host = self.host, port = self.port,
database = self.database
))This part is pretty strange for me:
loop.run_until_complete(create_pool(
user = environ.get('PG_USERNAME'),
password = environ.get('PG_PASSWORD'),
host = self.host, port = self.port,
database = self.database
))Why we should create pool via loop object?
- asyncpg version: 0.25.0
- PostgreSQL version: latest
- Do you use a PostgreSQL SaaS? No
the issue with a local PostgreSQL install?: No
- Python version: 3.8
- Platform: MacOS
- Do you use pgbouncer?: No
- Did you install asyncpg with pip?: Yes
- If you built asyncpg locally, which version of Cython did you use?: -
- Can the issue be reproduced under both asyncio and
uvloop?: I dont know
There is some code abstraction coded with aiogram: ```python async def check_rights(message: types.Message): return await bot['db_pool'].fetch_query('SELECT is_admin FROM users WHERE id = $1::varchar(30) and username = $2::varchar(30)', str(message.chat.id), message.from_user.username) @bot_dispatcher.message_handler(check_rights, commands=['add_admin']) async def add_admin(message: types.Message): print('is_admin!') ``` That's how `bot['db_pool']` is created: ```python async def on_startup(): db = Database() bot = Bot(token=token) bot_dispatcher = Dispatcher(bot) try: await db.setup_pool() except asyncpg.exception.InvalidPasswordError: logging.ERROR("Username or password if incorrect") exit(-1) else: bot['db_pool'] = db bot['getMeInfo'] = await bot.get_me() print(await bot['db_pool'].test()) return bot, bot_dispatcher ``` And database object as well: ```python class Database(object): def __init__(self): if environ.get('DEBUG'): self.host, self.port, self.database = '127.0.0.1', 5432, 'test' else: self.host, self.port, self.database = environ.get('PG_HOST', 'postgres'), environ.get('PG_PORT', 5432), environ.get("PG_DATABASE") @property def get_pool(self): return self.pool async def setup_pool(self): self.pool = await create_pool( user = environ.get('PG_USERNAME'), password = environ.get('PG_PASSWORD'), host = self.host, port = self.port, database = self.database ) async def fetch_query(self, query: str, *args): async with self.pool.acquire() as connection: async with connection.transaction(): return await connection.fetchval(query, *args) async def test(self): return await self.fetch_query("select 2 ^ $1", 1) ``` Well if I am creating event loop like this: ```python loop = new_event_loop() bot, bot_dispatcher = loop.run_until_complete(on_startup()) ``` And starting bot like this: ```python if __name__ == "__main__": print(f"[+] Bot started with username: {bot['getMeInfo'].username}") executor.start_polling(bot_dispatcher, skip_updates=True) ``` I can't execute POOL methods, for example: ```python async def check_rights(message: types.Message): return await bot['db_pool'].fetch_query('SELECT is_admin FROM users WHERE id = $1::varchar(30) and username = $2::varchar(30)', str(message.chat.id), message.from_user.username) ``` Error trace: ``` Task exception was never retrieved future: