search

MagicTheGathering / mtg-sdk-java

Magic: The Gathering SDK - Java
MIT License
69 stars 24 forks source link

Card.equals() throws NullPointerException #23

Closed yannekflick closed 5 years ago

yannekflick commented 5 years ago

If the Manacost is null, the equals method of class Card throws a NullPointerException. Flipcards like Nicol Bolas (m19) have no manacosts.

thechucklingatom commented 5 years ago

Oops, that should be looking at cmc, not Mana cost. I'll build a test out for that and fix it tonight.

thechucklingatom commented 5 years ago

I will likely have to change it a bit as well, since there are a few cards that wouldn't have multiverseId's. I will be adding test coverage around that as well.

thechucklingatom commented 5 years ago

Should be resolved in 09f0a2be3bc390bd74adebba4c4e37620b37e683 Let me know if you have any more issues! Release 0.0.12 has been created.