MaibornWolff / codecharta

CodeCharta is a visualization tool that transforms complex software architecture and code metrics into interactive, customizable visual maps, empowering everyone to communicate and analyze your codebase. Improve code quality, maintainability, and architectural decisions
https://maibornwolff.github.io/codecharta/
BSD 3-Clause "New" or "Revised" License
194 stars 30 forks source link

Fix/3747/no reload on deleting invisible map #3788

Closed BenediktMehl closed 1 month ago

BenediktMehl commented 1 month ago

no reload on deleting invisible map

{Issue/Closes}: #3747

Description

When deleting an invisible map/file, the visible maps are not reloaded.

I decided to implement a custom compare mechanism, instead of dividing the "files" Attribute of the CcModel into "visibleFiles" and "invisibleFiles". I did this, because that would mean a lot of new logic that would have to search for the files in both fields, remove files from arrays, add files to arrays,... which seemed too complex and too inperformant for me.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

Screenshots or gifs

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud