MaikuMori / helm-charts

Maiku's Helm charts
https://artifacthub.io/packages/search?user=MaikuMori&sort=relevance
MIT License
18 stars 11 forks source link

Probes fail when Basic Auth is enabled #37

Closed wegerts closed 3 months ago

wegerts commented 3 months ago

First thank you for providing and maintaining this chart! :-)

Just found after enabling basic auth the probes fail due to 401 responses. Can be easily fixed by adding an httpHeader to the probes as follows:

        livenessProbe:
          failureThreshold: 3
          httpGet:
            httpHeaders:
            - name: Authorization
              value: Basic <base64: user:password>
            path: /health
            ...
        readinessProbe:
          failureThreshold: 3
          httpGet:
            httpHeaders:
            - name: Authorization
              value: Basic <base64: user:password>
            path: /health
            ...
MaikuMori commented 3 months ago

This actually seems like an upstream bug.

The health endpoints should be outside of auth. I'll keep this open until I can check with the upstream project, and because it provides a good workaround.

MaikuMori commented 3 months ago

@wegerts this has been fixed upstream, just need to wait for the next release.

wegerts commented 3 months ago

@MaikuMori Thank you!

MaikuMori commented 2 months ago

This chart now ships with Gotenberg version, which has the fix included.