search

MailOnline / videojs-vast-vpaid

video.js vast plugin
MIT License
296 stars 231 forks source link

VAST behaviour before FLV video played on demand #164

Open michalk-k opened 8 years ago

michalk-k commented 8 years ago

There are initial conditions of test case:

  1. main video is FLV, so flash player is in use
  2. vast video is MP4 (not sure if it does matter)
  3. autoplay is disabled

If I start player by hitting big play button (in top left corner), then:

  1. vast starts to play
  2. spinner doesn't disappear, vast progress doesn't move
  3. after vast finishes, everything stops until mouse click
  4. mouse click initializes regular vast play
  5. after this play, main video is going to be played as expected

Please note, issue doesn't appear if either autoplay is enabled or main video uses html5 player (ie mp4).

Is it real issue or I did something wrong?

with regards

additional info: videojs v5.8 videojs swf v 5.0.1 videojs-vast-paid ver 1.0 recent (for videojs5)

michalk-k commented 8 years ago

edit: initially I though I found the videojs issue because it appears even if no preroll is played (none provided). But after removed the plugin from videojs, player started to work properly.

michalk-k commented 8 years ago

Guys I prepared testcase for this issue

I cannot host this page (sorry for that), but I put it onto github. videojs and videojs-vast-vpaid code is included from public repos (demo pages, including airplane vast). Only flash video is from other site.

Testcase shows 2 the same videos, One starts immediately after page load, second waits for user input. The second suffer from the issue I described in the first post.

testcase

michalk-k commented 8 years ago

Guys I really need a fix to this issue. I would say it's critical one.

thx

michalk-k commented 8 years ago

Any news on it? Please.

kirrie commented 8 years ago

@michalk-k

try this patch.

https://github.com/kirrie/videojs-vast-vpaid/commit/47c0856adbd47e25af57f73ebbe885d15683e019

as i wrote in comment, i think that it's caused by not firing 'seeked' event at the very first time in playing video in flash tech. this patch trigger 'seeked' event manually after first 'seeking' event fired once. but this is not proper way to solve problem. it's a monkeypatch. use it at your own risk. ;-)

michalk-k commented 8 years ago

Thank you for your effort. Unfortunately it doesn't fix the issue in my test case