Don't set `externalTrafficPolicy` when `externalService` is `ClusterIP`

baby-gnu commented 1 year ago

Describe the bug

I can't deploy the helm with the following values.yaml:

front:
  hostPort:
    enabled: false

  externalService:
    enabled: true
    type: ClusterIP

I get the following error:

Error: Service "mailu-front-ext" is invalid: spec.externalTrafficPolicy: Invalid value: "Local": may only be set when `type` is 'NodePort' or 'LoadBalancer'

Environment

Kubernetes Platform Scaleway

Additional context

I have an existing nginx ingress as LoadBalancer with correct TCP service forwarding.

emouawad commented 9 months ago

+1 same here

jlxq0 commented 1 month ago

Same. Did anyone figure this out?

WebSpider commented 1 month ago

I'll see if i can provide a PR for this

jlxq0 commented 1 month ago

What's the workaround, @WebSpider?

WebSpider commented 1 month ago

Sorry, real life happend. Thanks for tagging me, ill PR tonight.

Its a matter of putting an extra 'if' in the template that creates the service.

jlxq0 commented 1 month ago

How do we get this merged now? 😇

Mailu / helm-charts

Don't set `externalTrafficPolicy` when `externalService` is `ClusterIP` #266