MakePrisms / bitcoinmints

List, review, and find bitcoin mints.
https://bitcoinmints.com
18 stars 6 forks source link

Reviews not working for fedimints #20

Closed Kodylow closed 2 months ago

Kodylow commented 3 months ago

the button is disabled for fedimint reviews unless the cashu url is filled , for fedimint reviews shouldn't be required

image

gudnuf commented 3 months ago

Looks like the issue is I'm putting the fed pubkey in the "Federation Invite Code" field:

value={mintType === Nip87MintTypes.Cashu ? mintUrl : mintPubkey}

And disabling based on invite code:

            disabled={!inviteCode && !mintUrl}

Should that input be the pubkey or invite code?

Kodylow commented 3 months ago

use the inviteCode, the federationId is a hash of part of the config file it's not useful as a human level identifier